Skip to content

feat(autoware): add CropBoxFilter (#748) - #803

Open
romancardenas wants to merge 2 commits into
tier4:mainfrom
romancardenas:autoware/crop_box_filter
Open

romancardenas wants to merge 2 commits into
tier4:mainfrom
romancardenas:autoware/crop_box_filter

Conversation

@romancardenas

@romancardenas romancardenas commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

This solves #748.

This PR builds on top of #802.

It emulates the implementation of ROS2 Autoware v1.8.0.

The main difference with the baseline implementation is error handling. Now, point cloud creation and manipulation enforces more checks to ensure that the underlying data has a correct outline.

  • Results match the reference implementation for identical inputs and parameters (check crop_box_filter/tests/autoware_cases.rs).
  • Tests cover empty inputs, boundary points, and invalid coordinates according to the reference behavior.
  • Timestamp and coordinate-frame metadata are preserved or updated consistently with the defined interface.
  • Execution time and memory usage are measured across representative input sizes.

Regarding memory usage, the system does not allocate heap memory when processing an incoming point cloud. However, it does store the output point cloud data on a new vector.

@ytakano Regarding this pending point, I wonder if there are examples for benchmarks in autoware. In the past, I used Criterion for benchmarking, but it looks like the repository is not set for this.

How was this PR tested?

  • scripts/ci.sh passes on my machine.
  • Unit tests of the new module pass on my machine

@romancardenas
romancardenas force-pushed the autoware/crop_box_filter branch from 7c6114b to 3c443ee Compare November 18, 2026 07:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant