Repository navigation
feat(autoware): add CropBoxFilter (#748) - #803
Open
romancardenas wants to merge 2 commits into
Open
romancardenas wants to merge 2 commits into
romancardenas wants to merge 2 commits into
Conversation
romancardenas
force-pushed
the
autoware/crop_box_filter
branch
from
November 18, 2026 07:23
9187f8a to
7c6114b
Compare
romancardenas
force-pushed
the
autoware/crop_box_filter
branch
from
November 18, 2026 07:44
7c6114b to
3c443ee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This solves #748.
This PR builds on top of #802.
It emulates the implementation of ROS2 Autoware v1.8.0.
The main difference with the baseline implementation is error handling. Now, point cloud creation and manipulation enforces more checks to ensure that the underlying data has a correct outline.
crop_box_filter/tests/autoware_cases.rs).Regarding memory usage, the system does not allocate heap memory when processing an incoming point cloud. However, it does store the output point cloud data on a new vector.
@ytakano Regarding this pending point, I wonder if there are examples for benchmarks in autoware. In the past, I used Criterion for benchmarking, but it looks like the repository is not set for this.
How was this PR tested?
scripts/ci.shpasses on my machine.