Skip to content

feat(autoware): Add PointCloud struct - #802

Merged
nokosaaan merged 1 commit into
tier4:mainfrom
romancardenas:autoware/point_cloud
Nov 18, 2026
Merged

nokosaaan merged 1 commit into
tier4:mainfrom
romancardenas:autoware/point_cloud

Conversation

@romancardenas

Copy link
Copy Markdown
Contributor

Description

This is part of #748.

This PR builds on top of #801.

It addresses @nokosaaan 's comments in #783. The idea is trying to get an alternative implementation that avoids allocations in the heap. I will divide the contribution in several PRs, as it will ease the review process.

This PR adds the PointCloud structure. Unlike in ROS2's autoware, the message fields are private, and fields are checked at construction time to avoid overflows.

The structure itself contains multiple convenience methods to access to and iterate over points.

How was this PR tested?

  • scripts/ci.sh passes on my machine.
  • Unit tests of the new module pass on my machine

@romancardenas

Copy link
Copy Markdown
Contributor Author

@nokosaaan I addressed your suggestions. Let me know your opinion!

@nokosaaan

Copy link
Copy Markdown
Contributor

@romancardenas
Thanks! LGTM.

nokosaaan
nokosaaan previously approved these changes Nov 18, 2026
@romancardenas
romancardenas dismissed nokosaaan’s stale review November 18, 2026 07:06

The merge-base changed after approval.

@nokosaaan
nokosaaan requested a balanced review from Copilot November 18, 2026 07:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@romancardenas

Copy link
Copy Markdown
Contributor Author

@nokosaaan I rebased from main. It will probably need another review.

@nokosaaan

Copy link
Copy Markdown
Contributor

I see. I'm trying to ask Copilot to review it, but if that doesn't work, I'll ask Professor Takano instead.

@nokosaaan
nokosaaan requested an adaptive review from Copilot November 18, 2026 07:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@nokosaaan

Copy link
Copy Markdown
Contributor

@romancardenas
I didn't notice that the “approve” status had been reset. Sorry.

@nokosaaan
nokosaaan merged commit 14c45b7 into tier4:main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants