Repository navigation
feat(autoware): Add PointCloud struct - #802
Merged
Merged
Conversation
This was referenced Nov 17, 2026
nokosaaan
requested changes
Nov 18, 2026
romancardenas
force-pushed
the
autoware/point_cloud
branch
from
November 18, 2026 06:28
5002417 to
1b190a2
Compare
Contributor
Author
|
@nokosaaan I addressed your suggestions. Let me know your opinion! |
Contributor
|
@romancardenas |
nokosaaan
previously approved these changes
Nov 18, 2026
romancardenas
dismissed
nokosaaan’s stale review
November 18, 2026 07:06
The merge-base changed after approval.
romancardenas
force-pushed
the
autoware/point_cloud
branch
from
November 18, 2026 07:12
1b190a2 to
e7ee71c
Compare
Contributor
Author
|
@nokosaaan I rebased from main. It will probably need another review. |
Contributor
|
I see. I'm trying to ask Copilot to review it, but if that doesn't work, I'll ask Professor Takano instead. |
nokosaaan
approved these changes
Nov 18, 2026
Contributor
|
@romancardenas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part of #748.
This PR builds on top of #801.
It addresses @nokosaaan 's comments in #783. The idea is trying to get an alternative implementation that avoids allocations in the heap. I will divide the contribution in several PRs, as it will ease the review process.
This PR adds the
PointCloudstructure. Unlike in ROS2's autoware, the message fields are private, and fields are checked at construction time to avoid overflows.The structure itself contains multiple convenience methods to access to and iterate over points.
How was this PR tested?
scripts/ci.shpasses on my machine.