Repository navigation
Update apko packages to v7.3.0 (main) - #2054
Open
ske-renovate-operator[bot] wants to merge 1 commit into
Open
ske-renovate-operator[bot] wants to merge 1 commit into
ske-renovate-operator[bot] wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
stackit-ske-bot
left a comment
Collaborator
There was a problem hiding this comment.
Renovate Update Verification Report
- Classification: Red (Blocked)
- Model Used: gemini-4-argon
- Dependency:
xfsprogs,xfsprogs-core,xfsprogs-extra(7.2.1->7.3.0)
Impact Analysis
- Adaptation Rationale: Code changes in
pkg/csi/blockstorage/nodeserver.goare required before this update can be merged:- In
formatAndMountRetry(pkg/csi/blockstorage/nodeserver.go#L280-L283, introduced instackitcloud/cloud-provider-stackit#1411followingstackitcloud/cloud-provider-stackit#549), XFS volumes are formatted withformatOptions := []string{"-n", "parent=0", "-i", "exchange=0,nrext64=0"}. - With
xfsprogs7.3.0, invokingmkfs.xfs -n parent=0 -i exchange=0,nrext64=0 <dev>fails immediately withmetadir not supported without exchange-range supportbecausemetadir=1is now enabled by default and conflicts with-i exchange=0. - Additionally, when that initial format call fails,
formatAndMountRetryrescans the device and retriesm.Mounter().FormatAndMount(devicePath, stagingTarget, fsType, options)atpkg/csi/blockstorage/nodeserver.go#L296withoutformatOptions, formatting the volume with all7.3.0incompat features (metadir=1,parent=1,exchange=1,nrext64=1), which then failsmounton node kernels older than Linux 6.13. - Updating
formatOptionsto disablemetadir([]string{"-m", "metadir=0", "-n", "parent=0", "-i", "exchange=0,nrext64=0"}or[]string{"-c", "options=/usr/share/xfsprogs/mkfs/lts_5.10.conf"}) and preservingformatOptionson the rescan retry path resolves the issue.
- In
- Breaking Changes: Upstream
xfsprogsv7.3.0includesmkfs: enable metadata directory trees by default (Darrick J. Wong), setting.sb_feat.metadir = true(-m metadir=1, superblock flagXFS_SB_FEAT_INCOMPAT_METADIR) by default inmkfs/xfs_mkfs.c. Invalidate_sb_features(),mkfs.xfsrejectsmetadir=1combined with an explicit-i exchange=0flag (metadir not supported without exchange-range support). Furthermore,XFS_SB_FEAT_INCOMPAT_METADIRrequires Linux kernel 6.13+ to mount.
Verification Results
- Build & Test Output:
GOOS=linux golangci-lint run ./...: Passed (0 issues.)../hack/test.sh ./cmd/... ./pkg/... ./test/...: Passed across all unit test suites (pkg/ccm,pkg/cmp,pkg/csi/blockstorage,pkg/csi/util,pkg/csi/util/mount,pkg/labels,pkg/metrics,pkg/stackit/client,pkg/stackit/stackiterrors,test/kubetest2).CGO_ENABLED=0 go build ./cmd/stackit-csi-plugin/main.go&CGO_ENABLED=0 go build ./cmd/cloud-controller-manager/main.go: Succeeded.apko build cmd/stackit-csi-plugin/apko-base-image.yaml ... --arch amd64,arm64: Succeeded, resolvingxfsprogs=7.3.0-r1,xfsprogs-core=7.3.0-r1, andxfsprogs-extra=7.3.0-r1for bothx86_64andaarch64.tools/csi-deps-check.sh(executed inside the builtamd64rootfs): Passed (mkfs.xfs version 7.3.0,xfs_io version 7.3.0,xfs_repair version 7.3.0,xfs_growfs version 7.3.0).- Active
mkfs.xfsverification inside the built7.3.0rootfs:/sbin/mkfs.xfs -n parent=0 -i exchange=0,nrext64=0 /tmp/test.img: Failed (metadir not supported without exchange-range support)./sbin/mkfs.xfs -m metadir=0 -n parent=0 -i exchange=0,nrext64=0 /tmp/test.img: Succeeded (exchange=0 metadir=0,parent=0,nrext64=0)./sbin/mkfs.xfs -f -c options=/usr/share/xfsprogs/mkfs/lts_5.10.conf /tmp/test.img: Succeeded.
Member
|
/hold seems we need to adopt the xfs settings again. Like we did here #1411 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
7.2.1→7.3.07.2.1→7.3.07.2.1→7.3.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate CLI.