Skip to content

Update apko packages to v7.3.0 (main) - #2054

Open
ske-renovate-operator[bot] wants to merge 1 commit into
mainfrom
renovate/main-apko-packages
Open

ske-renovate-operator[bot] wants to merge 1 commit into
mainfrom
renovate/main-apko-packages

Conversation

@ske-renovate-operator

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
xfsprogs minor 7.2.1 → 7.3.0
xfsprogs-core minor 7.2.1 → 7.3.0
xfsprogs-extra minor 7.2.1 → 7.3.0

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@ske-renovate-operator ske-renovate-operator Bot added the kind/upgrade Upgrading components or dependencies (e.g., by renovate) label Nov 17, 2026
@ske-renovate-operator
ske-renovate-operator Bot requested a review from a team November 17, 2026 06:37
@ske-prow

ske-prow Bot commented Nov 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mstueer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2026

@stackit-ske-bot stackit-ske-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate Update Verification Report

  • Classification: Red (Blocked)
  • Model Used: gemini-4-argon
  • Dependency: xfsprogs, xfsprogs-core, xfsprogs-extra (7.2.1 -> 7.3.0)

Impact Analysis

  • Adaptation Rationale: Code changes in pkg/csi/blockstorage/nodeserver.go are required before this update can be merged:
    • In formatAndMountRetry (pkg/csi/blockstorage/nodeserver.go#L280-L283, introduced in stackitcloud/cloud-provider-stackit#1411 following stackitcloud/cloud-provider-stackit#549), XFS volumes are formatted with formatOptions := []string{"-n", "parent=0", "-i", "exchange=0,nrext64=0"}.
    • With xfsprogs 7.3.0, invoking mkfs.xfs -n parent=0 -i exchange=0,nrext64=0 <dev> fails immediately with metadir not supported without exchange-range support because metadir=1 is now enabled by default and conflicts with -i exchange=0.
    • Additionally, when that initial format call fails, formatAndMountRetry rescans the device and retries m.Mounter().FormatAndMount(devicePath, stagingTarget, fsType, options) at pkg/csi/blockstorage/nodeserver.go#L296 without formatOptions, formatting the volume with all 7.3.0 incompat features (metadir=1, parent=1, exchange=1, nrext64=1), which then fails mount on node kernels older than Linux 6.13.
    • Updating formatOptions to disable metadir ([]string{"-m", "metadir=0", "-n", "parent=0", "-i", "exchange=0,nrext64=0"} or []string{"-c", "options=/usr/share/xfsprogs/mkfs/lts_5.10.conf"}) and preserving formatOptions on the rescan retry path resolves the issue.
  • Breaking Changes: Upstream xfsprogs v7.3.0 includes mkfs: enable metadata directory trees by default (Darrick J. Wong), setting .sb_feat.metadir = true (-m metadir=1, superblock flag XFS_SB_FEAT_INCOMPAT_METADIR) by default in mkfs/xfs_mkfs.c. In validate_sb_features(), mkfs.xfs rejects metadir=1 combined with an explicit -i exchange=0 flag (metadir not supported without exchange-range support). Furthermore, XFS_SB_FEAT_INCOMPAT_METADIR requires Linux kernel 6.13+ to mount.

Verification Results

  • Build & Test Output:
    • GOOS=linux golangci-lint run ./...: Passed (0 issues.).
    • ./hack/test.sh ./cmd/... ./pkg/... ./test/...: Passed across all unit test suites (pkg/ccm, pkg/cmp, pkg/csi/blockstorage, pkg/csi/util, pkg/csi/util/mount, pkg/labels, pkg/metrics, pkg/stackit/client, pkg/stackit/stackiterrors, test/kubetest2).
    • CGO_ENABLED=0 go build ./cmd/stackit-csi-plugin/main.go & CGO_ENABLED=0 go build ./cmd/cloud-controller-manager/main.go: Succeeded.
    • apko build cmd/stackit-csi-plugin/apko-base-image.yaml ... --arch amd64,arm64: Succeeded, resolving xfsprogs=7.3.0-r1, xfsprogs-core=7.3.0-r1, and xfsprogs-extra=7.3.0-r1 for both x86_64 and aarch64.
    • tools/csi-deps-check.sh (executed inside the built amd64 rootfs): Passed (mkfs.xfs version 7.3.0, xfs_io version 7.3.0, xfs_repair version 7.3.0, xfs_growfs version 7.3.0).
    • Active mkfs.xfs verification inside the built 7.3.0 rootfs:
      • /sbin/mkfs.xfs -n parent=0 -i exchange=0,nrext64=0 /tmp/test.img: Failed (metadir not supported without exchange-range support).
      • /sbin/mkfs.xfs -m metadir=0 -n parent=0 -i exchange=0,nrext64=0 /tmp/test.img: Succeeded (exchange=0 metadir=0, parent=0, nrext64=0).
      • /sbin/mkfs.xfs -f -c options=/usr/share/xfsprogs/mkfs/lts_5.10.conf /tmp/test.img: Succeeded.

@dergeberl

Copy link
Copy Markdown
Member

/hold

seems we need to adopt the xfs settings again. Like we did here #1411

@ske-prow ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/upgrade Upgrading components or dependencies (e.g., by renovate) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants