Repository navigation
Conversation
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
/cc @stackitcloud/ske-infrastructure |
Member
|
/test pull-cloud-provider-stackit-e2e-verify-flatcar |
dergeberl
reviewed
Nov 20, 2026
| var formatOptions []string | ||
| if fsType == util.FSTypeXfs { | ||
| // With newer xfsProgs version newer features are enabled by default. This forces mkfs.xfs to use flags compatible | ||
| // with the linux LTS 5.10 kernel |
Member
There was a problem hiding this comment.
Can we add a comment here which flag is possible with which kernel version, so we have the info later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36
/cherry-pick release-v1.37
/hold
What this PR does / why we need it:
metadir=1is enabled by default in xfsProgs 7.3. However this requires atleast a linux kernel 6.13 or higher. Since we currently keep compatibility with the LTS 5.10 we'll disable the feature.In the future we'll enable the customer to specify custom XFS formatOptions.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: