Skip to content

csi: disable metadir feature in mkfs.xfs that is supported with linux 6.13 kernels and update xfsprogs - #2064

Open
nschad wants to merge 2 commits into
mainfrom
xfs-kernel-flags
Open

nschad wants to merge 2 commits into
mainfrom
xfs-kernel-flags

Conversation

@nschad

@nschad nschad commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

How to categorize this PR?
/kind enhancement

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36
/cherry-pick release-v1.37
/hold

What this PR does / why we need it:

metadir=1 is enabled by default in xfsProgs 7.3. However this requires atleast a linux kernel 6.13 or higher. Since we currently keep compatibility with the LTS 5.10 we'll disable the feature.

In the future we'll enable the customer to specify custom XFS formatOptions.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 20, 2026
@ske-prow

ske-prow Bot commented Nov 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xoxys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2026
@dergeberl

Copy link
Copy Markdown
Member

/cc @stackitcloud/ske-infrastructure

@ske-prow
ske-prow Bot requested a review from a team November 20, 2026 13:40
@dergeberl dergeberl changed the title csi: disable metadir feature that is supported with linux 6.13 kernels csi: disable metadir feature in mkfs.xfs that is supported with linux 6.13 kernels and update xfsprogs Nov 20, 2026
@dergeberl

Copy link
Copy Markdown
Member

/test pull-cloud-provider-stackit-e2e-verify-flatcar
/test pull-cloud-provider-stackit-e2e-verify-ubuntu-2604

var formatOptions []string
if fsType == util.FSTypeXfs {
// With newer xfsProgs version newer features are enabled by default. This forces mkfs.xfs to use flags compatible
// with the linux LTS 5.10 kernel

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here which flag is possible with which kernel version, so we have the info later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants