Skip to content

fix(extension): release page capture and composer improvements - #9564

Merged
waleedlatif1 merged 2 commits into
mainfrom
codex/extension-0-1-2-release
Nov 2, 2026
Merged

waleedlatif1 merged 2 commits into
mainfrom
codex/extension-0-1-2-release

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Backport fix(extension): attach Sim pages and streamline composer controls #9560 to production: attach ordinary Sim pages, add the shared current-page composer shortcut, and keep large attachment stacks reachable without nested desktop scrolling.
  • Exclude revealed secrets from page and selection capture; retain embedded-route, document identity, and user-gesture guards.
  • Disclose Go Links suggestion and resolution data handling. Observe the packaged no-gesture check without the test runner introducing activation.

Type of Change

  • Bug fix

Testing

  • Full root tests, 29 workspace type-checks, 62 audits, lint, four generators, and block-registry validation.
  • Packaged extension: 23 checks passed; removing only the gesture guard fails the intended negative control.
  • Real app: 33 checks passed, one live-provider check skipped; 66 screenshots cover narrow layouts, both composers, mixed attachments, large stacks, and access changes.
  • Go Links: 12 real HTTP checks, 50 requests. The production build matches the reviewed 0.1.2 package byte-for-byte.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

)

* fix(extension): attach Sim pages and streamline composer controls

* fix(extension): normalize Sim paths before capture

* fix(extension): exclude revealed secrets and keep large composers usable
@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 2, 2026 6:42pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR allows ordinary Sim pages to be attached while continuing to block embedded extension pages.

  • The extension attaches regular Sim pages but skips embedded extension chats and marked secrets.
  • Workspace and organization extension chats offer an “Attach current page” button.
  • Tall composers scroll as a whole so their attachments and controls stay reachable.
  • The privacy policy explains what the Sim address-bar shortcut sends and records.

No actionable issues were found. This review checked source code; it did not rerun the reported tests.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  User[User clicks current-page shortcut] --> Bridge[Existing capture bridge]
  Bridge --> Guard[Check gesture and active page]
  Guard --> Extract[Read text and skip excluded content]
  Extract --> Composer[Add removable page attachment]
  Composer --> Send[User reviews and sends]
Loading

Reviews (1) · Last reviewed commit: "fix(extension): disclose link handling a..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit eb6fa57 into main Nov 2, 2026
138 of 140 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/extension-0-1-2-release branch November 2, 2026 19:18

This branch was successfully deployed

1 active deployment
Preview — a812676c Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant