Skip to content

fix(extension): attach Sim pages and streamline composer controls - #9560

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/extension-dia-capture
Nov 2, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/extension-dia-capture

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Allow ordinary Sim pages to attach while excluding embedded extension routes, sensitive fields, and shared revealed-secret controls.
  • Add a current-page button with a tooltip beside Skills through the shared workspace and organization composer slots.
  • Let desktop attachments wrap without nested scrolling; keep the complete composer reachable when a large attachment stack exceeds the available height. Preserve the existing narrow-touch limit.

Type of Change

  • Bug fix

Testing

  • 42,550 tests passed with 8 existing skips across 20 workspace tasks. All 29 workspace type-checks, 62 audits, lint, generators, and block-registry checks passed.
  • Packaged extension: 23 checks passed, including credential exclusion from page and selected-text capture, guarded bridge behavior, and HTTP/HTTPS Sim Links redirects with encoded paths and queries.
  • Authenticated application acceptance: 33 checks passed, one live-provider check skipped, and zero browser errors. Real pointer submissions preserve 20 files plus a page in new workspace, existing workspace, and organization chats. Screenshots cover 320/390px themes, capture/preview/removal, permissions, recovery, and sign-out.
  • Sim Links HTTP acceptance: 12 checks and 50 requests passed, including permissions, organization isolation, encoded values, visits, and auditing.
  • Regression tests failed before the capture, composer, scrollbar, shortcut, and revealed-secret fixes; guard-removal controls verify capture security. Cleanup and test-audit completed.
  • Native Dia acceptance remains unverified because the native folder picker could not be controlled; no temporary extension was left loaded. Live-provider generation was not rerun. This PR targets staging; it does not publish a Chrome Web Store update.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 2, 2026 6:08pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 10 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/extension/src/capture.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptileai review this PR

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found.

Summary

Allows ordinary Sim pages to attach, adds a current-page button to the shared composers, and lets oversized composers scroll.

  • Sim pages attach to chats without including embedded routes or revealed secrets.
  • Extension chats have a button for attaching the current page.
  • Large attachment stacks expand the composer instead of trapping it in nested scrolling.

Reviews (2) · Last reviewed commit: "fix(extension): exclude revealed secrets..." · Reviewed by Greptile

Comment thread apps/extension/src/capture.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2e6bbb1 into staging Nov 2, 2026
50 of 52 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/extension-dia-capture branch November 2, 2026 18:05
menotbobbybrown pushed a commit to menotbobbybrown/sim that referenced this pull request Nov 2, 2026
…mstudioai#9560)

* fix(extension): attach Sim pages and streamline composer controls

* fix(extension): normalize Sim paths before capture

* fix(extension): exclude revealed secrets and keep large composers usable
waleedlatif1 added a commit that referenced this pull request Nov 2, 2026
* chore(ci): give the Trigger.dev upload job room for a slow image push (#8115)

(cherry picked from commit 43c9f6c)

* improvement(extension): document browser data handling and limited use

* fix(extension): attach Sim pages and streamline composer controls (#9560)

* fix(extension): attach Sim pages and streamline composer controls

* fix(extension): normalize Sim paths before capture

* fix(extension): exclude revealed secrets and keep large composers usable

* fix(extension): disclose link handling and keep gesture checks passive

---------

Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com>
Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Theodore Li <theo@sim.ai>

This branch was successfully deployed

1 active deployment
Preview — 32bd39c1 Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant