Skip to content

Add _RequestSent event #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 2 commits into from
Sep 20, 2016
Merged

Add _RequestSent event #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2446717
Drop `Headers` from the name of `_ResponseHeadersSent`
alexwlchan Sep 20, 2016
a3cfea3
Add a `_RequestSent` event for symmetry
alexwlchan Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions h2/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,20 @@ class _HeadersSent(object):
pass


class _ResponseHeadersSent(_HeadersSent):
class _ResponseSent(_HeadersSent):
"""
The _ResponseHeadersSent event is fired whenever response headers are sent
The _ResponseSent event is fired whenever response headers are sent
on a stream.

This is an internal event, used to determine validation steps on
outgoing header blocks.
"""
pass


class _RequestSent(_HeadersSent):
"""
The _RequestSent event is fired whenever request headers are sent
on a stream.

This is an internal event, used to determine validation steps on
Expand Down
8 changes: 4 additions & 4 deletions h2/stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
RequestReceived, ResponseReceived, DataReceived, WindowUpdated,
StreamEnded, PushedStreamReceived, StreamReset, TrailersReceived,
InformationalResponseReceived, AlternativeServiceAvailable,
_HeadersSent, _ResponseHeadersSent, _TrailersSent
_HeadersSent, _ResponseSent, _RequestSent, _TrailersSent
)
from .exceptions import (
ProtocolError, StreamClosedError, InvalidBodyLengthError
Expand Down Expand Up @@ -133,7 +133,7 @@ def request_sent(self, previous_state):
"""
self.client = True
self.headers_sent = True
event = _HeadersSent()
event = _RequestSent()

return [event]

Expand All @@ -146,7 +146,7 @@ def response_sent(self, previous_state):
if self.client is True or self.client is None:
raise ProtocolError("Client cannot send responses.")
self.headers_sent = True
event = _ResponseHeadersSent()
event = _ResponseSent()
else:
assert not self.trailers_sent
self.trailers_sent = True
Expand Down Expand Up @@ -1041,7 +1041,7 @@ def _build_hdr_validation_flags(self, events):
events[0], (_TrailersSent, TrailersReceived)
)
is_response_header = isinstance(
events[0], (_ResponseHeadersSent, ResponseReceived)
events[0], (_ResponseSent, ResponseReceived)
)
except IndexError:
# Some state changes don't emit an internal event (for example,
Expand Down