Repository navigation
Add _RequestSent event - #320
Merged
Merged
Conversation
Make sure we actually emit it somewhere, or coverage gets cranky.
Lukasa
approved these changes
Sep 20, 2016
Lukasa
left a comment
Lukasa
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for this @alexwlchan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix for issue #314, since I was already poking around in this code.
I dropped the name "Headers" from the two events, for symmetry the corresponding
-Receivedevent names.I also tweaked
request_sent()to use the new event, otherwise coverage gets antsy about the class we’ve defined but never used.