Repository navigation
feat: Fitness and Health fit the window with one view at a time - #63
Open
atharva-acharya wants to merge 1 commit into
Open
atharva-acharya wants to merge 1 commit into
atharva-acharya wants to merge 1 commit into
Conversation
atharva-acharya
enabled auto-merge (squash)
November 1, 2026 15:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fitness and Health no longer scroll as a page. Each shows one view at a time, chosen with a segmented control under the title:
Every view stays mounted, so switching is instant and charts keep their state; a view taller than the window scrolls inside itself. The page titles lose their eyebrow labels, as on the other redesigned pages. With the ring fix from #59, Health's rings are no longer clipped.
Checked in the real app at 1440 x 900 (windowed) and 1655 x 900 (maximised): no page scroll on either page. Unit tests pass (the Health tab-order test now checks the page tabs and the range tabs separately); e2e opens each view before checking it.