Skip to content
This repository was archived by the owner on Mar 11, 2020. It is now read-only.

fs2-core-1.0.0-M5 - #64

Merged
rossabaker merged 2 commits into
Verizon:masterfrom
dbousamra:chore/upgrade-fs2-cats-effect
Oct 9, 2018
Merged

rossabaker merged 2 commits into
Verizon:masterfrom
dbousamra:chore/upgrade-fs2-cats-effect

Conversation

@dbousamra

Copy link
Copy Markdown
Contributor

I've upgraded FS2 to 1.0.0-M5. This in turn upgrades cats-effect to 1.0.0.

@dbousamra
dbousamra force-pushed the chore/upgrade-fs2-cats-effect branch from 789b7cd to f604b5a Compare September 10, 2018 01:06

@rossabaker rossabaker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed now, or do you want to wait for fs2-1.0.0, which is due in early October?

We used to have an automated publishing pipeline, which rejected milestones, which would mean burning two major versions to release this now and later. I suppose we could release this as a milestone now?

@dbousamra

dbousamra commented Sep 18, 2018 •

Copy link
Copy Markdown
Contributor Author

Not needed now. Merge whenever.

@tpolecat

tpolecat commented Oct 8, 2018 •

Copy link
Copy Markdown
Contributor

Can we update to 1.0.0 and merge and publish? I'm blocked on this.

@tpolecat

tpolecat commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

Thanks @rossabaker 👍

@rossabaker

Copy link
Copy Markdown
Contributor

I think @wedens is correct on #61 about Resource#load and replacing the watcher, but this is no worse than what we had before.

How about we release this as 7.0.0-M1 to unblock, and we can clean up the rest as 7.0.0? Otherwise, it'll be two major version bumps.

@rossabaker

Copy link
Copy Markdown
Contributor

Merging this now. Discussion of release ongoing in Nelson gitter.

@rossabaker
rossabaker merged commit 93856e4 into Verizon:master Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants