[wedens]

Most changes are s/Effect/ConcurrentEffect/g. Also ExecutionContext is now required only when resolving ConcurrentEffect which makes notificationPool useless.

[timperrett]

@adelbertc how does this affect us with nelson? @rossabaker for visibility

[wedens]

And please tell me if I've missed some place where specific ExecutionContext was important (blocking or something). It's difficult to spot due to it being implicit.

[rossabaker]

Thanks, @wedens!

What made the strengthening of the constraint to ConcurrentEffect necessary? I'm guessing you followed the errors, but I'm not spotting it myself.

This would require eventually upgrading Nelson to cats-effect-1.0 as well. That will require http4s-0.19, and similar work in helm. I think it's important to keep the libraries current anyway, especially as they get toward this LTS release. Nelson can upgrade at its own pace.

[wedens]

Concurrent+Effect+cancellation=ConcurrentEffect.

What previously required Effect+ExecutionContext, now requires Concurrent+Effect.

Concurrent is required for Stream#joinUnbounded, signalOf and most other stuff from fs2. Effect is required for Effect#runAsync in loadp (from knobs package object). Any code path that loads a config leads to loadp. Cancellation (currently) is not used in knobs (directly or transitively).

Using F[_]: ConcurrentEffect is a bit more convenient than F[_]: Effect : Concurrent, but I can change to the later, if you think it's worth it.

UPD: I think this runAsync can be replaced with Sync[F].delay(Effect[F].toIO(fa).unsafeRunSync)) if blocking is really necessary here. But it still requires Effect.

[wedens]

Also, I suspect Resource#load should be shifting to some blocking ExecutionContext (this PR doesn't change it)

[wedens]

Looks like it's already updated in master. Closing.