Repository navigation
Conversation
Signed-off-by: mday-io <mdaytn@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
8 of 10 tasks
Signed-off-by: mday-io <mdaytn@gmail.com>
mday-io
force-pushed
the
feat/automatic-query-execution-context
branch
from
October 31, 2026 23:30
6889176 to
b57bc31
Compare
Signed-off-by: mday-io <mdaytn@gmail.com>
Signed-off-by: mday-io <mdaytn@gmail.com>
Signed-off-by: mday-io <mdaytn@gmail.com>
mday-io
force-pushed
the
feat/automatic-query-execution-context
branch
from
November 1, 2026 21:50
b57bc31 to
a695f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
query_execution_context: true, SQLMesh now supplies model-batch contextwithout an application-defined provider. Warehouse SQL and observer callbacks
can use the same operation ID during
Context.apply()and built-in scheduler runs.This PR depends on #6173 and includes
that provider until the parent lands.
The automatic-only comparison
shows the additional changes.
Native observation events create an immutable context with model, snapshot,
operation ID, and available interval and batch index. Nested audits reuse the
batch ID. Callbacks read it through
get_query_execution_context().observer;
observer_scope(None)disables it explicitly.remain authoritative, including when they return
None.A supported, enabled warehouse adapter without a custom provider activates the
observer. State-only opt-in does not. Coverage is model batches and nested audits,
with broad phases. Standalone operations and detailed per-statement roles are
outside this scope.
Test Plan
Style and fast tests were rerun after inheriting the test-only DuckLake cache fix.
Earlier checks remain applicable because the automatic-only patch is unchanged.
make styleand all sixmake fast-testphases passed. 2,999 passed,13 skipped.
audit-only batches, malformed facts, restoration, disablement, and custom providers.
plan/apply/run checks matched batch and audit IDs across provider, automatic,
and default-console modes. Rows, hashes, snapshots, and intervals matched;
default state SQL had no context.
passed with DuckDB 1.5.6 after the previous extension-install failure. The
inherited worker-cache fix passed all four DuckLake adapter cases.
unavailable locally; remote warehouses were not exercised locally.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO