Repository navigation
Conversation
Signed-off-by: mday-io <mdaytn@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueAutofix is paused · Paused
|
8 of 10 tasks
|
Autofix was enabled. Check current status in the Coding task. |
Signed-off-by: mday-io <mdaytn@gmail.com>
Signed-off-by: mday-io <mdaytn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SQLMesh's plan and run markers identify the parent job in warehouse query history,
but not the model evaluation behind each statement. This PR adds an opt-in
provider so applications can use the same evaluation ID in SQL and observer records.
Enable
query_execution_contexton a connection and supply an adapter providerthat returns an immutable
QueryExecutionContext. SQLMesh appends version-oneJSON after the existing correlation marker, once SQL is rendered.
or serialization errors omit optional context and let the query continue.
exclude the default state adapter.
propagate the original
BaseException.The flag defaults to
false. Without a provider, enabled adapters can emitparent-only context. Athena and other adapters without generic comment support
skip this transport. A runnable DuckDB example connects context to observer events.
#6174 adds automatic model context.
Test Plan
Style and fast tests were rerun after the test-only DuckLake cache fix. Earlier
feature checks remain applicable because feature code and examples are unchanged.
make styleand all sixmake fast-testphases passed. 2,984 passed,13 skipped.
including real SQLite rollback and later transaction reuse.
plan/apply/run checks matched observer and SQL IDs across six batches and audits.
Rows and hashes were unchanged; default state SQL had no rich context.
passed with DuckDB 1.5.6 after the previous extension-install failure. All four
DuckLake cases passed with worker-owned caches. The isolation mutation failed
as expected; local serial/two-worker checks passed.
unavailable locally; remote warehouses were not exercised locally.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO