Skip to content

Fix exposure not applying from Corrosive Elements notable - #3148

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
Wires77:corrosiveElementFix
Aug 30, 2021
Merged

LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
Wires77:corrosiveElementFix

Conversation

@Wires77

@Wires77 Wires77 commented Aug 15, 2021

Copy link
Copy Markdown
Member

From: https://discord.com/channels/645607528297922560/680796887259021342/875478517486321694 and https://discord.com/channels/645607528297922560/680796887259021342/871321272167067688

Sample build to test with:

eNrFW91z2kgSfw5_hYqqeyNGo29RZLcwxjYb2-HASe6eUmNpAK0HiUgjbGdr__frGQkQBOxGuavLgyKJX3_39HQPuPv784JrK5ZmURJ_aJIzvamxOEjCKJ59aH6-v3zvNX__rdEdUTH_ND3PIy4_-a3xrqvuNc5WjANdUxM0nTHxZc3J_AacljQWc5bEt_TPJL1Kwg_NuyRmTe2BxmEk1k8Bp1l2RxfsQ3MSAHFTo1nA4rC_fV8AFzSKJ0nwyMRVmuRLJXYVsafbJATM8Hb0aXxfERrFVaGg87vuiNMXlk4EFVoGlw_NHphOZ-w6EsCK8hz4EI9YZy4hht1sv0p0QRdwPYFusmQs3OLPLMOzXVJe__9Eo5QNplMWiGjF-mkk-nMaB1v7jpp1KvY25yJa8oilFQ2PUlz_xJzo-jHwfSIovxhNNljD9o0zy7Kcwvb_DV2yTZ6jmn2NxPycQ1RqSJG0w1kcCVaTeJREWRL_gn1V0qMm9pPFQxTXsnBN2lvNTiW9pTHtJ9k2BIZ5DHoTTdkO9KgpgwkON4YCgENKNUcshbomcARS2ZMIJiKt-O6oxux7FXiU2wV73nLTX-FWBR7FDeOtAf5r3KpAYtvHtVslQm0VGDduUK7xSsEMOhI7jAMc089xyjKWrip19jj7XYIyrJiCJgnHbMbiajG3XkPfMBbMr2CnHFPBcHm5QXn2q_6RWJR_JPCAf46z3yU4wT-ScNc_xtmrpeJE93ylaYgoFzFLZy-TecQ4Aq18WSVB-bRKsGsxiuREuwcrmlXXF3Fet6aA45KDwTYIBCHDNg2nU4zS5E_ZyPDTyHrpIslTZAQLMMrk0fwliwLYSVXHOGZhHuCq16Yfu01WbAFrQjV20O9uA3OM9JxDp7xn-GsGcX4SRU8IGjxeJOGMnSTkJIrLKAVvZVFl-3vvINCfoEHv0yWmZZGLCStgi0YLuIlmcxHDyISXskeCt2VOk-wEY7ZwtIjLnHNUKzh5jHaRgj5w1tH0Z-L5xAgc7-hSSZ5AmbkcJjPEwqqgb-m2ETnaAl6mLP7xgua_A0cJGMRhnsrsRsvYp_hZTLethm15N1wsk1Sol33Kg0yxHMbLXGixmpQXURZ8e8inUzkUN0FEqib5weXloH8__DIotaiSZDJY3-J88SAnsuL_bWGZMFWrtCDhnC4zBvP0lPIMeEdhGegJ1OdAoPAwzZVjMwYNu2-QRuBEDFiOYSiV1WyMQcphFQWEqFDO8A67f1kymQEZ1mdlwcSg1ZCJQhZTIc5ANX3iwsAC-oJCbloSFHrAWS_icg_Eee0WFkKxfeLwsKGl0UMukNmm5gqUHrLBRhlYbSKRqwMHLNsalBJl34fBlnsNLimhtUCH7YJNGaQ7ctmrcnJPH1lcFst1YeyqtZZpGVTMK7bIzl9gR7qU7t07q9gBwF6V5sA7ZFOac_n-nznlkXiRJbzy9qY4-YTZWMvmydMkXy4LNnJxZ-D0m5vikx4XJQcpY617YZlUUB1r9lSXp56V-upsM4oDnocwkpb77sZuTh-k7KY2k-eg_SSPYR-JIy7PbuVGG66N2GMtuUrB77qgSom94skD5caGt9oNbqMYPL6nTuWT8mXvIUt4LoNzzxZLTtM_8lCeiPKtb6pCyFotxWmoMjP4WaIS9r1w2VBVFOVzsJYt5PMtEzSkgraHAhzall5tK0K4Uwy_VwK255Cg8BUIkHuf7ON_VuKoXUU6FrJUphUJJm_vU8Y0WnhaMSVlhOGhepwt9QetYticwX-u6Xkt13f0luk4rteyDVs3Wrbt607LNC3XbxmOa-ktx7Ydr2V6uuW1HNN3HfnGJepqqqulMH7LMlzgRnTLV1Su3jJ8l0ieJiAN3ffcluUaNtDqpg8SPc80m5oA9StH98QuT-ULdYuUGYSwBYR3UvN28ebz-EbdvJsLscw67fbT09PZkop5MmXPMHudBcmivQQ24JX3ysHvpaB2D_6dq8uP4Po5Go0z_aux-Nh_NuY6_3hhOx-D4cfRUh_cze8-T3Pr8f0qVwLba4nd4muArBBfPimvSo2JYxAPlo8o8qXsvA7gCLF1BM4hnmlhcJbtmQicYfg-hp_lOa6P4WcSgoD5lo7xCqQiylqVWBgc8T0UPwfyEqOf6doYL5vEQUXDtCwUzraJj8kW3_VdTLLorokxV5aHLYwc94pjYpLAcsAMDE63dIy1xCSujoqGjkply8dZYfqolQa54mBi69seJhjE8lFyiUEcjB2GZ7kYubZFDBe1hoiPsZd4lumgKp_heSg_49a4CThkGqCyirgGLpsdz8PUKnCzg4mvZRHHR_nPcVD5R6BIonYO1_JQci2UX4humyi_-I6H27Fcx0P5GYAoubqHqi7Q9uDWpUMwOMcwUWIdH1V0HZ_g-gxTP1ANoM_cdjvwAC2l6j5lzylv7hIYWuVn8uX6QXWkXyL2pGWMpsF8IlI5MPxIksW_ZdW29DMXcskrZpRrRsUtXW6GAAkrB5wSIY8rLiKYp1M1mq37aQn8l_xmxzkzbbP4kqCr-vKyG5b3E1a03HnGYJZL4vAro0to9uXryjQkoWqkK4eUMU2hi-9o49540LgDSySgcSMPybQ-zzPBUu0P9sR4o5_SKfSmHU0q1RilbBo9dzT5s4_Nw18pjWeso5_Zf_emUx6pkRKcJaeDfpKmiWxSB1wdsmeNST7dsth52BGsqQGgo9ENx2-sYEH5t1ANpnsEsn3W1MDW0YjRKAfDjqY3lLvH7HtHc_TGEKaOKIhE1tHMxl9BYd7fvTDMgEobFS11IT3bfm5ogGDh3ucaTdla3SKPdjgCfrKgMIbuUc3AYVJJ_R9yDk0ZhcFbG6yt04qxu0EOidSiTNv4VNs4VSavDOEm2JAAr-RENRW6E56sjysLoEYmT3Sp9R5esoyuLdMOrZ4DpPtkBo7sddR5koispkKHbHlDqXPGxYkklzDSPWomSiXjkEpmPffinGD8l8iseko69aQ59b1ZJ5_eiMA14wsmThV0IJOcOnLeSL8rnqzkFyKnMzbrryJSR55VLxdIvcyz3g4PxrGnsj2UXjUNR9Udu4Y-NWqg-ZaY8EUrDsRPDN9hL9fKL7sOEWpJYgJRy067tluNGnF36q0ks176mqdnmVW_7NfIaVLb-SYmISwMqIbav9D8ICNZPwpOjaysH4ZfSBdsSZa0yFWDh9bw3DiKZ7hO4ORCcdS9NcsFPp51zDERfiL1w2DV9pZdxxrMeqmf5G-o1Fvk_MDeVoyTMDKq4xB16qB-GJPE02j2089c5JAZyRl9ELPFy-ZXVoPnZZLlqfyrlCThjMbl0Ub5XXLJq9ve_wuY_wB3b4Tw```

@Wires77 Wires77 added the bug Something isn't working label Aug 15, 2021
@Wires77
Wires77 requested a review from PJacek August 15, 2021 04:50

@PJacek PJacek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically fixes the issue but results in worse functionality than original. Now you can only view the config option and apply exposure if the main skill has the Fire, Cold or Lightning tags. There were no such restrictions before. That's because this bug was caused by you removing these lines:
dfe6984#diff-570218d1fe57724953e86ba16e300d2d6c5c7b94e23ca44b04f61a491faf2a6dL2261-L2263
They were there specifically to bypass the generic parser and stop it from applying the skill type tags. This little hack allowed for free control of exposures from config independently of the currently selected skill.

@Wires77

Wires77 commented Aug 17, 2021

Copy link
Copy Markdown
Member Author

Bleh, you're right. Seems hacky that we have to do it that way, but we don't have the config options look at skills globally, so I'll just re-add those lines back for now.

@ppoelzl ppoelzl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should come up with a better solution than sprinkling in checks for the main skill everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants