Repository navigation
Fix exposure from config and items not listed in Curses and Debuffs - #10512
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
Exposure that is not inflicted by a debuff skill (the "Is the enemy Exposed to X?" config used by Corrosive Elements, Mastermind of Discord and item "inflict Exposure on Hit" mods) lowered the enemy resistance but never showed in the Calcs tab Curses and Debuffs list, unlike Wave of Conviction. Record the exposure that is applied in calcs.perform and list it, with its resistance mod, when it does not come from a debuff skill that is already listed under the same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3232
Description of the problem being solved:
The damage part of the issue was fixed by #3148; what remained (see the last comment) is that exposure applied through the config, "Is the enemy Exposed to Lightning?" (Corrosive Elements, Mastermind of Discord), lowered the enemy resistance but was never shown in the Calcs tab "Curses and Debuffs" box, unlike Wave of Conviction. The same happened to any exposure not inflicted by a debuff skill (item or passive EnemyModifier sources).
Curses and Debuffsis built inCalcs.luaonly fromenv.debuffsand the curse slots, while exposure is resolved separately incalcs.perform(strongest exposure per element, plus extra exposure and exposure effect, capped byExposureMin).The fix records the exposure that is actually applied per element in
calcs.perform(env.appliedExposure, reset each pass) and, inCalcs.lua, lists it as "X Exposure" with its final resistance mod in theSkillDebuffsbreakdown, unless it comes from a debuff skill that is already listed (matched by source, or by a debuff of the same name, so Wave of Conviction's "Lightning Exposure" is not repeated).Steps taken to verify a working solution:
spec/System/TestExposure_spec.lua: config exposure is listed with -10 Lightning Resistance; with "an extra -5%" it lists -15; nothing is listed when the checkbox is off; with Wave of Conviction set to Lightning plus the config exposure, "Lightning Exposure" appears once. Ondevthe listing test fails; all pass on this branch.--tags=builds(the saved 3.13 builds): the same 900 failures, with identical messages, ondevand on this branch, so no saved-build output changed.Link to a build that showcases this PR:
Any build with a lightning skill and "inflict Lightning Exposure on Hit" (e.g. Corrosive Elements), with "Is the enemy Exposed to Lightning?" checked in the config.
Before screenshot:
Curses and Debuffs: empty; the -10% Lightning Resistance only shows inside Effective DPS Mod.
After screenshot:
Curses and Debuffs:
Lightning Exposure, hovering shows-10 LightningResistfrom Config.