Repository navigation
🐛 fix(discovery): accept literal PATH symlinks - #220
Merged
gaborbernat merged 2 commits intoNov 3, 2026
Merged
Conversation
Resolving a Python symlink can replace its recorded original executable with the system binary. Match the executable found on PATH so a literal lookup keeps the symlink name.
Windows needs the standalone Python directory on PATH when starting a temporary executable symlink. Keep that directory after the symlink's parent so the test reaches name matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A literal interpreter name could miss a symlink on
PATH.PythonInfo._satisfies_pathcompared the request with the resolved system executable's name, so discovery could skip the executable found under the requested name. It now compares the candidate's executable name. Fixes #188.Literal names after interpreter resolution
resolve_to_systemcan replaceoriginal_executablewhile retaining the candidate path inexecutable. The name check now uses that retained path.Behavior changes
Literal names now accept matching symlinks on
PATH. Absolute paths and version constraints keep their existing checks. On Windows, the comparison still removes the.exesuffix.Reported by Anthropic's OSS Scanner:
ANT-2026-9225HCHJ.