Repository navigation
zephyr: wrapper: disable cached heap on Intel platforms - #4673
Merged
lgirdwood merged 1 commit intoAug 24, 2021
Merged
Conversation
Tests with dynamic-pipeline topologies increase the complexity of alloc/free patterns for heap and these tests have uncovered new issues with heap corruption. Tests are reporting failed allocs although heap still has free space. Running same test with cached heap disabled shows no failures. The cached heap is already disabled for IMX targets, so build on this code and add a local ENABLE_CACHED_HEAP define to toggle the cached heap. BugLink: thesofproject#4494 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
andyross,
iuliana-prodan,
lgirdwood,
lyakh and
marc-hb
August 24, 2021 17:32
kv2019i
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
August 24, 2021 17:32
This was referenced Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a step back, but it seems the heap corrupt can still be hit and now with dynamic pipelines increasing the complexity of heap alloc/free patterns in SOF, the issue is hit much more easily than before.
This does incur a ~15-20% performance penalty, but given the recently added support to build with XCC, the current sof-test cases still pass on Intel cAVS2.5 targets, so this seems like a reasonable step to take now.
Tests with dynamic-pipeline topologies increase the complexity
of alloc/free patterns for heap and these tests have uncovered
new issues with heap corruption. Tests are reporting failed
allocs although heap still has free space. Running same test
with cached heap disabled shows no failures.
The cached heap is already disabled for IMX targets, so build on
this code and add a local ENABLE_CACHED_HEAP define to toggle
the cached heap.
BugLink: #4494
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com