Repository navigation
rebuild-testbench.sh: remove CMAKE_VERBOSE_MAKEFILE - #3363
Merged
Merged
Conversation
Make git status great again. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Default is verbose enough. VERBOSE=1 can still be used later at make time. Also change nproc to nproc --all because we don't care about offline processors. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Contributor
|
LGTM. |
marc-hb
marked this pull request as ready for review
August 28, 2020 19:35
marc-hb
requested review from
aiChaoSONG,
cujomalainey,
fredoh9,
lgirdwood,
lyakh,
ranj063 and
xiulipan
August 28, 2020 19:37
ymdatta
approved these changes
Aug 29, 2020
lgirdwood
approved these changes
Aug 31, 2020
Member
|
Looks like DUT HW issue on Jenkins. |
Member
|
SOFCI TEST |
Contributor
|
Shouldn't we be more consistent in scripts? After this PR we will have some with CMAKE_VERBOSE_MAKEFILE and some without. |
Member
Collaborator
Author
Which scripts still have CMAKE_VERBOSE_MAKEFILE on by default? I haven't spotted any recently besides the deprecated one this replaces (so it doesn't really count) PS: don't get me wrong, I think the default log level in automation should generally be quite high because it's unfortunately sometimes difficult to reproduce the exact CI environment and failure(s) locally. However:
|
Member
|
Ok, lets merge this and fix any other VERBOSE settings in a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 commits, see commit messages
Default is verbose enough. VERBOSE=1 can still be used later at make
time.
Also change nproc to nproc --all because we don't care about offline
processors.