Repository navigation
Conversation
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
November 10, 2026 15:51
dbaluta
marked this pull request as draft
November 10, 2026 15:51
Install the sof-ctl configuration files from tools/ctl/ipc3 and tools/ctl/ipc4 into <prefix>/share/sof/ctl, keeping the directory layout, e.g. /usr/share/sof/ctl/ipc4/eq_iir/flat.txt. The files are installed together with the tools by: cmake --install <build_dir> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
sof-ctl, sof-logger and sof-probes are installed to a hard-coded "bin" directory. Include GNUInstallDirs once in tools/CMakeLists.txt and install the binaries to CMAKE_INSTALL_BINDIR instead, so that distribution builds (e.g. Yocto) can override the install layout. The default layout is unchanged: binaries go to <prefix>/bin and the sof-ctl configuration files to <prefix>/share/sof/ctl. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open issues
What changed in this PR
Updates the tools’ CMake install rules to (1) use standard install directory variables and (2) install sof-ctl IPC3/IPC4 control configuration .txt files into <prefix>/share/sof/ctl while preserving the source directory structure.
Changes:
- Switch tool binary install destinations from hard-coded
binto${CMAKE_INSTALL_BINDIR}. - Add installation of
tools/ctl/ipc3andtools/ctl/ipc4.txtconfiguration files into${CMAKE_INSTALL_DATADIR}/sof/ctl. - Include
GNUInstallDirsintools/CMakeLists.txtto define standard install directory variables.
| File | Description |
|---|---|
| tools/probes/CMakeLists.txt | Install sof-probes into ${CMAKE_INSTALL_BINDIR} instead of bin. |
| tools/logger/CMakeLists.txt | Install sof-logger into ${CMAKE_INSTALL_BINDIR} instead of bin. |
| tools/ctl/CMakeLists.txt | Install sof-ctl into ${CMAKE_INSTALL_BINDIR} and add install rules for IPC3/IPC4 .txt config trees under ${CMAKE_INSTALL_DATADIR}/sof/ctl. |
| tools/CMakeLists.txt | Include GNUInstallDirs so ${CMAKE_INSTALL_BINDIR} / ${CMAKE_INSTALL_DATADIR} are defined. |
Review effort: Lite
| ) | ||
|
|
||
| install(TARGETS sof-logger DESTINATION bin) | ||
| install(TARGETS sof-logger DESTINATION "${CMAKE_INSTALL_BINDIR}") |
| ) | ||
|
|
||
| install(TARGETS sof-probes DESTINATION bin) | ||
| install(TARGETS sof-probes DESTINATION "${CMAKE_INSTALL_BINDIR}") |
Copilot stopped reviewing on behalf of
dbaluta due to an error
November 10, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the sof-ctl configuration files from tools/ctl/ipc3 and
tools/ctl/ipc4 into /share/sof/ctl, keeping the directory
layout, e.g. /usr/share/sof/ctl/ipc4/eq_iir/flat.txt.