Repository navigation
Conversation
lgirdwood
commented
Nov 10, 2026
lgirdwood
left a comment
lgirdwood
left a comment
Member
Author
There was a problem hiding this comment.
lets make sure we update the readme with build instructions and support
There was a problem hiding this comment.
🟡 Changes recommended
The boot service exposes unauthenticated root command execution when started, and unresolved Android build failures, SELinux startup requirements, and audio correctness defects remain.
6 open issues
What changed in this PR
Adds Android build and deployment support for the SOF remote telemetry server and CLI, adapting the existing Linux audio backends for Bionic and AOSP libraries.
Changes:
- Adds Soong targets, an Android init service, and standalone cross-build and ADB deployment commands.
- Adds compatibility handling for ALSA-free builds and differing TinyALSA/Tinycompress APIs.
- Adds Android firmware/debugfs paths, startup logging, and quick-start documentation.
| File | Description |
|---|---|
sof-remote-server/sof_remote_server.rc |
Defines boot startup on debuggable Android builds. |
sof-remote-server/sof_remote_server.c |
Adds Android defaults, startup logging, and discovery paths. |
sof-remote-server/Makefile |
Adds Android cross-compilation and ADB deployment. |
sof-remote-server/dapm_inspector.c |
Adds Android firmware and debugfs fallbacks. |
sof-remote-server/CMakeLists.txt |
Enables Android server builds and conditional linking. |
sof-remote-server/audio_backend_tinyalsa.c |
Adapts PCM and mixer operations for AOSP TinyALSA. |
sof-remote-server/audio_backend_compress.c |
Handles differing timestamp function signatures. |
sof-remote-server/audio_backend_alsa.c |
Supports builds without ALSA by forwarding to TinyALSA. |
sof-remote-server/Android.bp |
Defines vendor server and CLI Soong targets. |
README.md |
Documents Android build and deployment commands. |
Makefile |
Exposes Android targets and excludes artifacts from RPM sources. |
.gitignore |
Ignores Android build output directories. |
Review effort: Balanced
| set(TINYCOMPR_OBJ2 "${SOF_WORK_DIR}/tinycompress/src/lib/.libs/libtinycompress_la-compress_hw.o" CACHE FILEPATH "Path to tinycompress compress_hw.o") | ||
|
|
||
| if(ASOUND_LIB) | ||
| if(ASOUND_LIB OR ANDROID) |
Comment on lines
+76
to
+77
| ANDROID_CRTBEGIN ?= $(dir $(firstword $(wildcard $(AOSP_DIR)/out/soong/.intermediates/bionic/libc/crtbegin_dynamic/android_$(ANDROID_ABI)*/crtbegin_dynamic.o))) | ||
| ANDROID_CRTEND ?= $(dir $(firstword $(wildcard $(AOSP_DIR)/out/soong/.intermediates/bionic/libc/crtend_android/android_$(ANDROID_ABI)*/crtend_android.o))) |
Comment on lines
+10
to
+11
| on property:sys.boot_completed=1 && property:ro.debuggable=1 | ||
| start vendor.sof_remote_server |
Comment on lines
+44
to
+46
| #ifdef HAVE_TINYALSA_V2 | ||
| case SOF_PCM_FMT_FLOAT_LE: return PCM_FORMAT_FLOAT_LE; | ||
| #endif |
Comment on lines
+91
to
+92
| (void)ctl; | ||
| return fallback_idx; |
| # SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) | ||
| # Android init service for SOF Remote Telemetry & Debug Server | ||
|
|
||
| service vendor.sof_remote_server /vendor/bin/sof_remote_server -p 9998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Android (AOSP Soong and standalone NDK/AOSP Clang cross-compilation) build and deployment support for
sof-remote-server(sof_remote_serverandsof-remote):AOSP Soong Integration & Init Service:
sof-remote-server/Android.bpdefiningcc_binarytargets forsof_remote_serverandsof-remote(vendor: true, linkinglibtinyalsa,libtinycompress, andliblog).sof-remote-server/sof_remote_server.rcto startvendor.sof_remote_serveron boot whenro.debuggable=1.Standalone NDK / AOSP Cross-Compilation (
make android&make android-push):androidandandroid-pushtargets tosof-remote-server/Makefile, top-levelMakefile, andsof-remote-server/CMakeLists.txt.ANDROID_NDK_HOMEor an AOSP checkout (AOSP_DIR) and embedstinyalsaandtinycompressdirectly intobuild-android-<abi>/sof_remote_serverso it only depends on NDK system libraries (libc.so,libm.so,libdl.so,liblog.so) when pushed viaadb.Bionic & AOSP
external/tinyalsa/external/tinycompressAdaptations:audio_backend_alsa.c: Makesalsa-liboptional (HAVE_ALSA) and forwardsalsa_*calls totinyalsa_*when built withoutalsa-lib(-DNO_ALSA/__ANDROID__).audio_backend_tinyalsa.c: Supports both upstream TinyALSA v2 (<tinyalsa/pcm.h>,pcm_writei/pcm_readi) and AOSPexternal/tinyalsa(<tinyalsa/asoundlib.h>,pcm_write/pcm_read).audio_backend_compress.c: Uses C11_Generic(compr_get_tstamp_compat) to support both AOSP (unsigned long *) and upstream (unsigned int *)compress_get_tstampsignatures.sof_remote_server.c&dapm_inspector.c: Adds Androidlogcatlogging, defaultsg_tone_apitoSOF_AUDIO_API_TINYALSAon Android, and adds/vendor/firmwareand/ddebugfs fallback paths.Test Plan
make android(x86_64-linux-android34Bionic PIE binaries) andmake all(native Linuxx86_64binaries).readelf -donbuild-android-x86_64/sof_remote_server(NEEDED: liblog.so, libdl.so, libm.so, libc.so).