Repository navigation
test-case: add kernel log check after module insertion - #154
Merged
Merged
Conversation
Author
|
@xiulipan Ping for merge |
paulstelian97
previously approved these changes
Mar 30, 2020
Contributor
|
LGTM |
xiulipan
previously requested changes
Mar 30, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Good catch, but the multiple lines looks really bad.
If you think the single cmd is too long, use if else.
I don't think use this trick with multiple line is a good idea here.
added 2 commits
March 30, 2020 17:13
Signed-off-by: Amery Song <chao.song@intel.com>
Signed-off-by: Amery Song <chao.song@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we didn't check dmesg log after module insertion, so test case may passed even there is error in dmesg after module insertion. This patch fixes that condition.