Repository navigation
tarball_multi_releases.sh: downgrade symlink pre-check to WARNING - #101
Merged
Merged
Conversation
It should be fatal to release broken symlinks but resolving symlinks thanks to a combination of releases should be OK. So just WARN. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
September 15, 2022 19:22
Merged
marc-hb
requested review from
greg-intel,
keqiaozhang,
lgirdwood and
mengdonglin
September 15, 2022 19:24
mengdonglin
approved these changes
Sep 16, 2022
Contributor
|
@marc-hb Many thanks! It works for me. I removed duplicated v2.2 *.ri and *.ldc files in sof-v2.2.2 locally and can generated the tar ball with a nice warning. I'll update PR#98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be fatal to release broken symlinks but resolving symlinks thanks to a combination of releases should be OK. So just WARN.
Signed-off-by: Marc Herbert marc.herbert@intel.com