Repository navigation
PM related changes - #249
Merged
Merged
Conversation
lgirdwood
requested changes
Nov 7, 2018
plbossart
requested changes
Nov 7, 2018
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
Looks mostly good but multiple points are unclear or can be improved.
Member
|
@ranj063 let me know when you are a new version, I would like to test on top of some of my cleanups for module load/unload (where I still have the PM error message). |
Collaborator
Author
|
@plbossart @lgirdwood i've updated the PR based on previous comments now. |
ranj063
force-pushed
the
dsp_pg
branch
2 times, most recently
from
November 8, 2018 07:15
aa2e6c7 to
89c9edb
Compare
keyonjie
reviewed
Nov 8, 2018
keyonjie
left a comment
keyonjie
left a comment
There was a problem hiding this comment.
in general, looks we are lack of taking controller out of reset at resume?
plbossart
requested changes
Nov 8, 2018
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
We are making progress, thanks for this update!
Couple of fixes requited, e.g. function renaming needed for clarity, some comments desired and need to address Keyon's comment. Let's try and close this week.
ranj063
force-pushed
the
dsp_pg
branch
4 times, most recently
from
November 8, 2018 17:56
2b6bb6d to
6833ffe
Compare
Collaborator
Author
|
@plbossart @keyonjie @lgirdwood all comments addressed now. |
Member
|
@ranj063 the code looks good to me but there was a conflict introduced with an earlier merge of Xiuli's work. Can you fix and resubmit? Thanks! |
The patch does the following: 1. Move the runtime_put call for the pci dev to its probe routine 2. Use pm_runtime_put_noidle and pm_runtime_get_noresume in pci probe/remove Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
…r gating Add CGCTL/PGCTL bits that will be used for enabling/disabling clock gating and power gating respectively. Also, LP SRAM retention mode is enabled/disabled by BIT(4) of PGCTL register. So, fix the error in its name from PCI_CGCTL_LSRMD_MASK to PCI_PGCTL_LSRMD_MASK. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Collaborator
Author
|
@plbossart fixed the conflict now! |
plbossart
requested changes
Nov 9, 2018
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
couple of typos and doubts I have on the PM sequences that are worthy of comments as well.
Add pre/post ops that will be called to perform actions before and after fw run routine. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This patch defines pre/post fw run ops for SKL+ platforms. Disable clock gating, power gating and L1 support in pre_fw_run. Re-enable these in post_fw_run. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This patch does the following: 1. Reset HDA controller during suspend so that the PGD1 can be power gated. 2.Take controller out of reset during resume 3. This patch modifies the hda_dsp_ctrl_link_reset() method so it can be called to reset the controller during suspend. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Runtime PM for sof device in enabled in pcm_probe() after the topology load has completed. So autosuspend should be called after pm_runtime_enable() here. Remove the call to autosuspend() in sof_probe as this should be done after topology load has been completed. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Collaborator
Author
|
@plbossart fixed the typo and refs to fw_load now. |
plbossart
approved these changes
Nov 9, 2018
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
ok let's merge and start a validation cycle.
This was referenced Apr 25, 2019
Closed
aiChaoSONG
pushed a commit
to aiChaoSONG/linux
that referenced
this pull request
May 6, 2021
Finish RISC-V support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes these changes: