Repository navigation
Conversation
…nstall Add USE_SYSTEM_SYMENGINE (default ON). When OFF, SymEngine is built with ExternalProject at the commit in symengine_version.txt as a static library using Boost.Multiprecision. Add a CI job that exercises this path.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
USE_SYSTEM_SYMENGINECMake option. It defaults toONfor now, so the existing behaviour is unchanged.When
OFF,cmake/ExternalSymEngine.cmakebuilds SymEngine withExternalProject_Addat the commit insymengine_version.txt:INTEGER_CLASS=boostmp; SymEngine downloads the standalone Boost.Multiprecision headers itselfThis means
pip install symenginefrom an sdist works without a preinstalled SymEngine:Plans for future releases
USE_SYSTEM_SYMENGINE=OFFwill become the default in a future release, so a plainpip installfrom an sdist will work out of the box.USE_SYSTEM_SYMENGINE=ONand link against a SymEngine with batteries included (MPFR, MPC, FLINT, LLVM, etc.), so wheel users don't lose any features.symengine_version.txtis bumped to c3b2d541f2ffef52f4f8bb26c04c6c494bfce65f.CI
Adds a
build-bundled-symenginejob on ubuntu-24.04 and macos-15. It usesactions/setup-pythonwith no conda, so no SymEngine is installed beforehand. The job builds the sdist, installs from it with the bundled SymEngine, and runs the test suite from an empty directory.Tested locally on Linux: 262 passed, 107 skipped.
🤖 Generated with Claude Code