Repository navigation
Iterate on roxie integration - #304
mclasmeier wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
E2E Test ResultsCommit: 93502f2 |
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
bdf5f43 to
93502f2
Compare
mtodor
left a comment
There was a problem hiding this comment.
Tnx for provided updates! I have left a few comments - nothing that changes behavior.
| repository: stackrox/stackrox | ||
| path: stackrox-repo | ||
|
|
||
| # TODO(ROX-37886): Remove this and rely on stackrox/stackrox's scripts/roxie.sh instead. |
There was a problem hiding this comment.
Can we already use it? I see that script exists and it's used by existing ./deploy/deploy.sh that we have used before.
| uses: stackrox/actions/roxie/install-cli@bcda9b2d6d2b644c267e699479656973e84ef7fa # ratchet:stackrox/actions@v1 | ||
| with: | ||
| version: v0.4.17 | ||
| gh-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Let's remove gh-token for now. So far, we didn't have problems with installs without it.
Description
deploy.shtoroxiedirectly** —deploy.shis scheduled for removal.--resources tinyprofile — purpose-built for kind clusters on GHA runners.ROX_ENDPOINTandROX_ADMIN_PASSWORDvia its--envrcfile; forward allROX_*vars to subsequent steps instead of extracting them manually from deploy artifacts.Validation
Just CI.