Skip to content

Fix issue where some keyboards use the hint as composing text - #333

Merged
mgod merged 3 commits into
masterfrom
mw/composing-text
Dec 5, 2017
Merged

mgod merged 3 commits into
masterfrom
mw/composing-text

Conversation

@mgod

@mgod mgod commented Nov 29, 2017

Copy link
Copy Markdown
Contributor

Specifically seen as an issue on Android 8.0.0 LGE Nexus 5X with stock keyboard. To reproduce:

  1. open the sample project
  2. remove all the tokens
  3. type some letters, ending in a space
  4. you would have the first word in the hint text after the space

@mgod
mgod force-pushed the mw/composing-text branch 5 times, most recently from 9ccb2c0 to 554d340 Compare November 29, 2017 21:37
@mgod
mgod force-pushed the mw/composing-text branch from 554d340 to ac8106b Compare November 29, 2017 22:14
- Correctly tokenize when ", " is used instead of "," (or any split char)
- Fix an issue where completing a 3 letter token could re-add the 3 letters
	on the next letter added
@mgod
mgod force-pushed the mw/composing-text branch from 5afd102 to 383002c Compare December 5, 2017 21:54
@mgod

mgod commented Dec 5, 2017

Copy link
Copy Markdown
Contributor Author

Also close #308, #291, #242, #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant