Repository navigation
Remove Split::Cache and make config.cache a no-op - #771
Merged
Merged
Conversation
The cache lives in each process, so a winner set from the dashboard stayed stale in the other workers. It only saves 10 of 64 roundtrips on a dashboard page and none on ab_test, so it is no longer worth the risk. config.cache stays as an accessor so apps that set it keep booting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
Split::Cache, as planned in #735.The cache is held per process, so changes made in one worker (for example setting a winner from the Dashboard) never reached the others. After the recent roundtrip work it no longer pays for that risk. On a Dashboard of 10 experiments with 3 alternatives:
ab_testSplit.configuration.cachestays as an accessor, so apps that set it keep booting. It no longer does anything.cache = falsealready did.Split.cacheandSplit::Cacheare gone, so any code calling them directly needs to drop those calls.Closes #735
Closes #762
Supersedes #746, which bounded the staleness. Thanks @snaka for the work there and for the issues behind this change.
🤖 Generated with Claude Code