Repository navigation
fix: mark import occurrences with the Import role - #85
Merged
Merged
Conversation
maks-ivanov
commented
May 17, 2023
| this.document.occurrences.push( | ||
| new scip.Occurrence({ | ||
| symbol_roles: scip.SymbolRole.ReadAccess, | ||
| symbol_roles: scip.SymbolRole.Import | scip.SymbolRole.ReadAccess, |
Contributor
Author
There was a problem hiding this comment.
I don't know if the ReadAccess role is load-bearing in these cases. If not, I would remove those
maks-ivanov
changed the title
chrapkowski-sg
changed the title
chrapkowski-sg
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
Mark imported-target occurrences with
Import | ReadAccess. Keep ordinary later references asReadAccess.This is an import-role change only. The unrelated historical pip subprocess changes are excluded; current package discovery is preserved.
In response to the earlier review question, retain
ReadAccessfor compatibility. Removing it is not necessary to supply the missing import bit and would change existing consumer-visible behavior without demonstrated benefit. Plain-import alias modeling is unchanged.Verification