Skip to content

improvement(ci): overlap independent acceptance and recovery checks - #9559

Merged
waleedlatif1 merged 7 commits into
stagingfrom
codex/ci-acceptance-parallelism
Nov 2, 2026
Merged

waleedlatif1 merged 7 commits into
stagingfrom
codex/ci-acceptance-parallelism

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Run native extension interactions and access revalidation in parallel, with independent fixtures, apps, databases, and reports.
  • Overlap independent desktop-pickup deadlines and recovery backoff cases while preserving real PostgreSQL, Redis, HTTP, and timing assertions.
  • Use 4-vCPU Blacksmith integration runners with matching dependency setup and the existing GitHub fallback.
  • Align Playwright at 1.64.1, which includes the upstream WebKit compositor fix for filter transitions under capture load.

Type of Change

  • Improvement

Testing

  • Full hosted main CI passed with cold builds and two warm runs. The final head finished in 5m11s versus 7m21s on the same application baseline (30% faster); the earlier warm repeat took 5m28s. App build cache hits were verified. Integration, extension, and mobile case/status reports matched the baseline.
  • Root unit suite passed: 39,285 app tests with eight existing skips; workspace and script suites passed.
  • Extension groups retained exactly 31 passing checks and one existing skip; delaying access polling to 60 seconds failed the intended revocation assertion.
  • Desktop-pickup cases retained all seven results and reduced execution from 79s to 17s. Removing the claimed-call protection failed the two survival cases.
  • Recovery cases retained all 14 results and reduced execution from 199s to 51s; recovery plus sibling checks passed 17/17. Worker and fault misrouting controls failed as expected, and unknown HTTP/append/read identities failed the file after teardown.
  • Real Git/Turbo routing and aggregate-gate tests passed; the new group-selection expectations failed before implementation.
  • Root lint, all 29 workspace type checks, all 62 audits, block-registry invariants, and all four artifact generators passed. Actionlint, ShellCheck, Bash syntax, and diff checks passed; the full test-type ratchet reported no increases.
  • Matched Ubuntu filter-transition reproduction with tracing/screenshots: Playwright 1.61.1 crashed at 20/200 cycles while 1.64.1 passed 200/200. The fix is tracked in Playwright #42637 and the WebKit roll.
  • The desktop resize harness now disables focus emulation at the actual native blur boundary, after reloads. Its full 19-check Electron case passed twice; the pre-fix harness failed the focus assertion, and removing the production blur handler still failed the persistence assertion. All assertions and timing budgets remain intact.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 2, 2026 6:05am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issue was found.

Summary

The PR overlaps independent acceptance checks while keeping separate fixtures and reports.

  • Database integration jobs use 4-vCPU Blacksmith runners by default.
  • Browser-extension acceptance runs native and access checks in separate jobs.
  • Desktop pickup checks run independent waiting cases side by side.
  • Recovery exhaustion cases overlap with stream-specific worker fixtures.
  • Playwright 1.64.1 is used across workspace browser tests.

No actionable new issues or repository-rule violations were found. No previous review threads were supplied. Tests were not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Affected extension acceptance task] --> B[Shared production build]
  B --> C[Native interaction job]
  B --> D[Access revalidation job]
  C --> E[Separate app, database, profile and report]
  D --> F[Separate app, database, profile and report]
  E --> G[Aggregate CI gate]
  F --> G
Loading

Reviews (7) · Last reviewed commit: "test(desktop): disable focus emulation a..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 2, 2026 05:47
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptileai review this PR

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps please review the current head, including the Playwright engine update.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptileai

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5216fd4 into staging Nov 2, 2026
81 of 82 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-acceptance-parallelism branch November 2, 2026 06:36

This branch was previously deployed

1 inactive deployment
Preview — 3b17628f Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant