Repository navigation
Conversation
AI: Claude Opus 5.5 · effort unknown · main session: diagnosed the failing live test and quarantined it The google_reverse_image engine answers every query with HTTP 200, status "Success" and "Google Reverse Image hasn't returned any results for this query.", for three unrelated images that all download fine (search ids 6aec5ec26114bdb313a51f26, 6aec654ed65b8c309615cb4e, 6aec65590a89f6f211ca09ec). This is the engine, not the client, and it keeps master CI red. Mark the test @ignore with the evidence, as GoogleEventsTest and GoogleJobsTest already do, and assert image_sizes (as serpapi-ruby does) so the test checks real results once it is re-enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GoogleReverseImageTestfails on every run and keepsmasterCI red. Thegoogle_reverse_imageengine returns HTTP 200 withstatus: "Success"and only:This reproduced on 2026-11-05 with three unrelated images, all of which download fine:
https://i.imgur.com/5bGzZi7.jpg(the test image)6aec5ec26114bdb313a51f266aec654ed65b8c309615cb4e6aec65590a89f6f211ca09ecSo the problem is the engine, not the image or this client. The test also failed 0/3 on both
masterandimplement-image-apiduring review.Change
@Ignorewith the evidence in a comment, the same wayGoogleEventsTestandGoogleJobsTestalready handle engines that are broken upstream. JUnit 4.3 has noAssume, so the test can't skip itself at runtime.image_sizes, as serpapi-ruby does, so the test checks real results once it's turned back on.Testing
./gradlew testwithSERPAPI_KEYset (local, JDK 25, macOS): BUILD SUCCESSFUL, 42 passed / 0 failed / 3 skipped (GoogleReverseImageTest,GoogleEventsTest,GoogleJobsTest).Follow-up
Report the
google_reverse_imageengine to the SerpApi team, using the search ids above, and re-enable the test once it returns results again.🤖 Generated with Claude Code