Repository navigation
Conversation
rhenium
reviewed
Nov 11, 2026
| server_connect(port) { |ssl| | ||
| assert_equal [@svr_cert.subject, @ca_cert.subject], | ||
| ssl.peer_cert_chain.map(&:subject) | ||
| } |
Member
There was a problem hiding this comment.
The test failures are relevant. In TLS 1.3, SSL_connect() may return before SSL_accept() finishes writing NewSessionTicket. The usual workaround is to complete an application data round trip (ssl.puts("abc"); ssl.gets) to avoid the RST.
Maybe it's time to clean this up, since the same workaround is repeated in quite a few tests. But it would not belong to this PR.
Member
Author
There was a problem hiding this comment.
Oh, sorry. You're right. I've added one round trip and CI is green now.
Let's discuss how to clean this up as a separated task.
Allow adding a certificate per connection. This is the SSLSocket counterpart of SSLContext#add_certificate. This is a step toward configuring the SSL object directly from callbacks instead of switching the SSLContext. Ref ruby#1125 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kou
force-pushed
the
ssl-socket-add-certificate
branch
from
November 11, 2026 11:39
bb72f9b to
f5fbd44
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow adding a certificate per connection. This is the SSLSocket counterpart of SSLContext#add_certificate.
This is a step toward configuring the SSL object directly from callbacks instead of switching the SSLContext.
Ref #1125