Repository navigation
fix: unchecked *_set_* calls - #1044
Merged
Merged
Conversation
ndossche
force-pushed
the
clesss-15
branch
2 times, most recently
from
May 4, 2026 21:13
7144836 to
82c47b5
Compare
rhenium
reviewed
Nov 10, 2026
| if (!TS_RESP_CTX_set_certs(ctx, inter_certs)) { | ||
| err_msg = "Certificates could not be set"; | ||
| goto end; | ||
| } |
Member
There was a problem hiding this comment.
I created #1148 to refactor this method, since there are a few more issues that need to be fixed here.
Member
|
I rebased the branch onto current master to resolve merge conflicts, dropped the change for |
Member
|
Merged it, thanks for spotting and fixing! |
Contributor
Author
|
Thanks for taking this over and finalizing this ! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1038
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.