Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single socket read does not necessarily contain exactly the HTTP CONNECT response headers. Fragmented replies currently fail parsing or return before the headers finish; a reply coalesced with the first tunnel bytes discards those bytes.
Read through the complete
\r\n\r\ndelimiter in both HTTP connectors, leaving subsequent bytes in the existing stream for the caller. RFC 9110 §9.3.6 defines that boundary between response headers and tunnel data.The handshake uses one-byte
read(1)calls with explicit EOF handling so it works with all existing socket/TLS stream implementations without adding buffering APIs. Headers are bounded to 64 KiB; this does not change tunnel reads or the accepted status-code policy.Validation on current master
8d054e5:uv run pytest tests --cov=./python_socks --cov-report=term: 417 passed, 93% coverage.uv run ruff check python_socks tests,uv run ruff format --check python_socks tests, anduv run mypy python_socks tests: passed.Local validation used macOS arm64 / Python 3.12.13. Other Python versions and operating systems were not run locally. #33/#46 concern SOCKS5 reply parsing; this change is confined to HTTP CONNECT.
AI assistance: Codex authored the implementation and tests and ran the validation above. No human review has been performed.