Repository navigation
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The resume pages describe
nonceonly as a string forscript-src. React types that option asNonceOption, a string or an object with optionalscriptandstyleproperties.resumeToPipeableStreamtakesResumeOptions, whosenoncefield isNonceOption. Node, browser, and edgeresumeuse that samenoncetype. Those types live inpackages/react-dom/src/server/ReactDOMFizzServerNode.js, with the samenoncefield on the browser and edge server files.What changed
nonceentries onresumeandresumeToPipeableStreaminclude the object-form sentence already on the render pages.Scope
Blast Radius
Readers of the two resume pages can see that
nonceaccepts an object withscriptandstyleproperties. The sentence matches the render pages. The diff adds no links, headings, or code.Verification
prettier --checkonresume.mdandresumeToPipeableStream.mdpassed..prettierignoreexcludes those markdown files. Prettier with that ignore disabled also fails on these pages atorigin/main, so the existing formatting stays.eslinton the two files passed, andnode scripts/headingIdLinter.json the two files passed.git diff origin/main...HEADchanges two prose lines. This PR does not include ayarn build.