Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

$this->v8->executeString() needs to be echoed in ReactJS.php #2

Open

Description

@rickmurt

I did a cURL on the page I set up to verify that PHP had indeed echoed both the markup and the JS, and what I found was that the JS was outputted, but the markup didn't get generated until the page loaded (curl request resulted in <div id="page"></div>). When I inspected the table element, the data was there, so the JS initialized it. If you view source immediately, you'll see an empty #page as well.

Since you have an output buffer in ReactJS::getMarkup(), you have to echo, like so:

ob_start();
*echo* $this->v8->executeString($js);      
return ob_get_clean();

Once I added the echo and did a cURL request, I noticed that the markup was actually there before the JS had a chance to render it.

I'd put in a pull request, but I just wanted to verify that this was intended behavior and I wasn't missing anything.

Activity

  1. zpao commented on Feb 24, 2015

    @zpao
    Member

    This repo isn't super active so I'm not sure if you'll get a good response, but cc @stoyan for good measure.

  2. ddon commented on Feb 26, 2015

    @ddon

    @zpao if this repo is not active, do you know if this lib is still developed? So much noise about React these days, and I think to try it out with PHP, and google search gives this library as a first result.

  3. zpao commented on Feb 26, 2015

    @zpao
    Member

    It's not being used by us and it has basically not been updated since release (https://github.com/reactjs/react-php-v8js/commits/master). There is really not a ton to do here since the feature set is very small. It would be great to have some tests and then we can sort of coast.

  4. allantatter commented on Mar 21, 2015

    @allantatter

    What is the alternative? Not using anything or is it closed source?

  5. zpao commented on Mar 23, 2015

    @zpao
    Member

    We don't use this or anything like it.

  6. carlos22 commented on Apr 13, 2015

    @carlos22

    @rickmurt Thats not true, because the executed JS Code (https://github.com/reactjs/react-php-v8js/blob/master/ReactJS.php#L109) contains a print() function which is a php-v8js special global function that does echo (or print which is basically the same in php) the result. So this should work. See the v8js js api: https://github.com/preillyme/v8js#javascript-api and the examples below.

  7. rahim76 commented on Jul 14, 2018

    @rahim76

    good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions