Skip to content

Should remove the xmlns:xlink entirely, and replace xlink:href to xlinkHref #62

Open

Description

@reggi

I just used the html to jsx converter.

In the example of

<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#next-remove" />

It should remove the xmlns:xlink entirely, and replace xlink:href to xlinkHref.

Thoughts

Activity

  1. Daniel15 commented on Apr 24, 2016

    @Daniel15
    Contributor

    Is that actually HTML? <use> isn't a HTML tag.

  2. reggi commented on Apr 24, 2016

    @reggi
    Author

    It's used within <svg>. Unsure how it should be treated. Support for xlinkHref exists in jsx.

  3. rayshan commented on May 12, 2017

    @rayshan
  4. osdiab commented on Jun 2, 2017

    @osdiab

    xmlnsXlink is now supported in the React docs, so it probably shouldn't be eliminated. https://facebook.github.io/react/docs/dom-elements.html

    Probably a better option is just to handle namespaced attributes by camelCasing them and eliminating the colon, since that's invalid JSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions