Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
@react-native/babel-presetruns the class features plugins (transform-private-methodsandtransform-private-property-in-object, plustransform-class-propertieswhen classes are lowered) but not@babel/plugin-transform-class-static-block. Those plugins throw "Static class blocks are not enabled" on any class with astatic { }block, so an app file or dependency using one fails to bundle. The preset now adds the static block plugin next to the private methods plugin, so it only runs when the class features plugins do. Withunstable_preserveClassPrivatethe block is still left as is, like before.Fixes #59853
Changelog:
[GENERAL] [FIXED] - Babel preset no longer fails on class static blocks
Test Plan:
Added tests for a class with a static block under the
hermes-stableandhermes-legacyprofiles; both fail with "Static class blocks are not enabled" before the change.jest packages/react-native-babel-presetpasses and the existing transform snapshots are unchanged. The plugin's^7.26.0range is already inyarn.lock, so the lockfile doesn't change.