Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
hue-rotate()takes a CSS angle:deg,grad,rad, orturn.processFilteracceptsdegandrad.gradandturnreturnundefined, so the whole filter list becomes[].This change converts
gradas360/400degrees andturnas360degrees.deg,rad, unitless0, and unknown units stay the same. The native CSS angle parser already uses the same factors (gradisvalue * 0.9,turnisvalue * 360).Open PR #59138 still has
testUnitFilter('hue-rotate', 1.5, 'grad', [])in its newprocessBackdropFilter-itest.js.Changelog:
[GENERAL] [FIXED] -
filter: hue-rotate()now acceptsgradandturnangle units instead of dropping the whole filterTest Plan:
processFilter-itest.jsexpectshue-rotate(100grad)to be 90 degrees,0.5turnto be 180 degrees,-0.25turnto be -90 degrees, and1footo be dropped.Fantom and native builds were not run locally. CI will run them.
ANDROID_SDK_ROOTandANDROID_HOMEare unset, soyarn fantomwas not run.processFilteris pure JS, so the itest was run under Jest. A throwaway wrapper stubs@react-native/fantom/src/setUpDefaultReactNativeEnvironmentand requires the itest. That wrapper is not in this PR.On the fix commit's parent (
384b4409c5), these cases failed:hue-rotate(100grad)string hue-rotate(100grad)hue-rotate(0.5turn)string hue-rotate(0.5turn)hue-rotate(-0.25turn)string hue-rotate(-0.25turn)Result: 6 failed, 116 passed, 122 total.
On head (
7ff64de6b7) those six cases passed. Result: 122 passed, 122 total.Also ran:
yarn eslint --max-warnings 0onprocessFilter.jsandprocessFilter-itest.js(exit 0)yarn prettier --checkon those same files (exit 0)yarn flow-check(Found 0 errors)