Repository navigation
Declare Buffer#subarray in the flow-typed node libdef - #59737
Open
SamChou19815 wants to merge 1 commit into
Open
SamChou19815 wants to merge 1 commit into
SamChou19815 wants to merge 1 commit into
Conversation
Summary:
Node's `Buffer#subarray` returns a `Buffer` that shares memory with the receiver. The node environment libdef declares `slice(): this` but no `subarray`, so `subarray` resolves to `Uint8Array#subarray` from Flow's builtins. TypeScript's library types that as returning `Uint8Array<TArrayBuffer>`, not `this`. Once Flow adopts that signature, `buf.subarray(...).toString('hex')` and `.equals(...)` stop checking.
Declare `subarray(start?: number, end?: number): this` next to `slice`, matching Node's API and `types/node`. Nothing changes under the current builtins.
Changelog: [Internal]
Differential Revision: D128877321
meta-cla
Bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128877321. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Node's
Buffer#subarrayreturns aBufferthat shares memory with the receiver. The node environment libdef declaresslice(): thisbut nosubarray, sosubarrayresolves toUint8Array#subarrayfrom Flow's builtins. TypeScript's library types that as returningUint8Array<TArrayBuffer>, notthis. Once Flow adopts that signature,buf.subarray(...).toString('hex')and.equals(...)stop checking.Declare
subarray(start?: number, end?: number): thisnext toslice, matching Node's API andtypes/node. Nothing changes under the current builtins.Changelog: [Internal]
Differential Revision: D128877321