[tcK1]

Summary:

When trying to use the @react-native/eslint-config with ESLint v9, we get an issue with the eslint-plugin-ft-flow:

Oops! Something went wrong! :(

ESLint: 9.39.2

TypeError: Error while loading rule 'ft-flow/define-flow-type': context.getAllComments is not a function

Looking into it, I noticed that our current version (^2.0.0) does not support ESLint v9. Only in version ^3.0.11 it show as a valid peer dependency version.

So, although we do have a flat config, we don't support ESLint v9 out of the box.

Changelog:

[General] [Fixed] - Fixed the issue when using the flat config with ESLint v9.

Test Plan:

I've made a repro repo: https://github.com/tcK1/Repro-ESLint9-RN

Updated the ESLint version to v9 and added the eslint-plugin-ft-flow version in the resolutions configuration in the package.json.

In this state, running yarn eslint . works as expected. To reproduce the issue, remove the resolutions field (and run yarn install again to update the dependencies) and run the command again.

[EmilJunker]

Please merge, I need this fix 🙏

[DHRUV-1000101]

@cortinico please see if it can be merged?

[tcK1]

Hey! Friendly reminder of this issue!

[meta-codesync]

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D121042705.

[meta-codesync]

@cortinico merged this pull request in 099bcb4.