Skip to content

do videos and votes #8

Open
Open

Description

@FlaviuSim
No description provided.

Activity

  1. ghost assigned on Sep 20, 2011
  2. mhjohnson commented on Sep 21, 2011

    @mhjohnson
    Member

    Lateef, thanks for merging those commits earlier!! :) I was looking at our code and was a little confused about what we're actually returning at the end of those classmethods. Can you help me re-write the tests in RTCtest.py to see if they are returning the clips specific to the floor videos?

  3. lateefj commented on Sep 21, 2011

    @lateefj
    Member

    I hadn't finished writing the test code I hadn't finished figuring out how that get_bill was going to work. The test code in RTCTest.py didn't really give me an idea of what we needed to validate. I was going to make a list of required params and validate they existed in the result set. What fields do you think we should validate get returned? Any other suggestions of things we should assert based on the get_by_bill? (FYI I miss clicked on closing the issue)

  4. mhjohnson commented on Sep 22, 2011

    @mhjohnson
    Member

    Lateef,

    Here is something that we probably need to check for: We query set of house video's based on a bill_id mentioned in those long 10 hour videos. They contain multiple clips (which just specify the time offsets). The query for the bill_id is specific to the house videos, not the clips.

    1. There are multiple clips in each video; some of those clips do not relate to the bill_id that was queried.
    2. We have to filter out the clips that do not related to the bill_id from each video object
    3. Therefore, we need to test are final result: the bill_id must appear in the array for each clip

    ie: we don't want to return a clip that has nothing to do with the bill

  5. lateefj commented on Sep 22, 2011

    @lateefj
    Member

    Yeah I added that filter will push this morning.
    On Sep 22, 2011 1:31 AM, "Matthew Johnson" <
    reply@reply.github.com>
    wrote:

    Lateef,

    Here is something that we probably need to check for: We query set of
    house video's based on a bill_id mentioned in those long 10 hour videos.
    They contain multiple clips (which just specify the time offsets). The query
    for the bill_id is specific to the house videos, not the clips.

    1. There are multiple clips in each video; some of those clips do not
      relate to the bill_id that was queried.
    2. We have to filter out the clips that do not related to the bill_id from
      each video object
    3. Therefore, we need to test are final result: the bill_id must appear in
      the array for each clip

    ie: we don't want to return a clip that has nothing to do with the bill

    Reply to this email directly or view it on GitHub:

    #8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions