You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lateef, thanks for merging those commits earlier!! :) I was looking at our code and was a little confused about what we're actually returning at the end of those classmethods. Can you help me re-write the tests in RTCtest.py to see if they are returning the clips specific to the floor videos?
I hadn't finished writing the test code I hadn't finished figuring out how that get_bill was going to work. The test code in RTCTest.py didn't really give me an idea of what we needed to validate. I was going to make a list of required params and validate they existed in the result set. What fields do you think we should validate get returned? Any other suggestions of things we should assert based on the get_by_bill? (FYI I miss clicked on closing the issue)
Here is something that we probably need to check for: We query set of house video's based on a bill_id mentioned in those long 10 hour videos. They contain multiple clips (which just specify the time offsets). The query for the bill_id is specific to the house videos, not the clips.
There are multiple clips in each video; some of those clips do not relate to the bill_id that was queried.
We have to filter out the clips that do not related to the bill_id from each video object
Therefore, we need to test are final result: the bill_id must appear in the array for each clip
ie: we don't want to return a clip that has nothing to do with the bill
Yeah I added that filter will push this morning.
On Sep 22, 2011 1:31 AM, "Matthew Johnson" < reply@reply.github.com>
wrote:
Lateef,
Here is something that we probably need to check for: We query set of
house video's based on a bill_id mentioned in those long 10 hour videos.
They contain multiple clips (which just specify the time offsets). The query
for the bill_id is specific to the house videos, not the clips.
There are multiple clips in each video; some of those clips do not
relate to the bill_id that was queried.
We have to filter out the clips that do not related to the bill_id from
each video object
Therefore, we need to test are final result: the bill_id must appear in
the array for each clip
ie: we don't want to return a clip that has nothing to do with the bill
Reply to this email directly or view it on GitHub:
Activity
mhjohnson commentedon Sep 21, 2011
Lateef, thanks for merging those commits earlier!! :) I was looking at our code and was a little confused about what we're actually returning at the end of those classmethods. Can you help me re-write the tests in RTCtest.py to see if they are returning the clips specific to the floor videos?
lateefj commentedon Sep 21, 2011
I hadn't finished writing the test code I hadn't finished figuring out how that get_bill was going to work. The test code in RTCTest.py didn't really give me an idea of what we needed to validate. I was going to make a list of required params and validate they existed in the result set. What fields do you think we should validate get returned? Any other suggestions of things we should assert based on the get_by_bill? (FYI I miss clicked on closing the issue)
mhjohnson commentedon Sep 22, 2011
Lateef,
Here is something that we probably need to check for: We query set of house video's based on a bill_id mentioned in those long 10 hour videos. They contain multiple clips (which just specify the time offsets). The query for the bill_id is specific to the house videos, not the clips.
ie: we don't want to return a clip that has nothing to do with the bill
lateefj commentedon Sep 22, 2011
Yeah I added that filter will push this morning.
On Sep 22, 2011 1:31 AM, "Matthew Johnson" <
reply@reply.github.com>
wrote: