Repository navigation
[tkinter] filedialog ask* functions can return an empty tuple when cancelled - #16642
Open
hoangchunghien wants to merge 2 commits into
Open
hoangchunghien wants to merge 2 commits into
hoangchunghien wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Nov 1, 2026
| # Cancelling a dialog gives an empty string or an empty tuple, depending on the Tk version. | ||
| assert_type(tkinter.filedialog.askopenfilename(), str | tuple[()]) | ||
| assert_type(tkinter.filedialog.asksaveasfilename(), str | tuple[()]) | ||
| assert_type(tkinter.filedialog.askdirectory(), str | tuple[()]) |
Collaborator
There was a problem hiding this comment.
Please delete these tests. They are unnecessary: now that we have gotten this right once, it's very unlikely to break in the future.
Contributor
Author
|
Removed them in b37beaa, thanks. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16637
askopenfilename,asksaveasfilenameandaskdirectorywere typed as returningstr, but when the dialog is cancelled they can return an empty tuple. Which one you get depends on the Tk version. I cancelled each function under Xvfb on Linux:askopenfilename()()asksaveasfilename()()askdirectory''()askopenfilenames()()askopenfile,asksaveasfileNoneNoneaskopenfiles()()So the three
strfunctions becomestr | tuple[()], as suggested in the issue. The others already match:askopenfilenamesisLiteral[""] | tuple[str, ...], the file-object ones returnNoneor an empty tuple as typed. I did not check Windows or macOS, where Tk uses native dialogs.Added
assert_typecases tocheck_tkinter.py.regr_test.py stdlib(3.13, 3.10, and win32),mypy_test.py stdlib/tkinter,pyright_test.py, black and flake8 pass locally.