Skip to content

frozendict is invariant (python 3.15) #16668

Open

Description

@IIIMADDINIII
# Mutable list is invariant
list1: list[int] = [10]
list2: list[int | None] = list1 # Error

# Immutable list (tuple) is covariant
tuple1: tuple[int, ...] = (10, )
tuple2: tuple[int | None, ...] = tuple1 # No Error

# Mutable dict is invariant
dict1: dict[str, int] = {"a": 10}
dict2: dict[str, int | None] = dict1 # Error 

# Immutable dict is also invariant????
fdict1: frozendict[str, int] = frozendict(a=10)
fdict2: frozendict[str, int | None] = fdict1 # Error
# But I think this should not be an error
# I think Key and Value should booth be covariant

As far as I understand: The Generic TypeVar parameters _KT and _VT do not have the option, covariant set:

_KT = TypeVar("_KT")
_VT = TypeVar("_VT")

class frozendict(Mapping[_KT, _VT]):

Coming from meta/pyrefly#5289

Pyrefly Playground:
https://pyrefly.org/sandbox/?project=v2.jVXbSsNAEP2VwTw0QshF8EUQwbciiiD4Yn3YNqEJtrvS3RRU_HfPzG5utRYTyMLczkxmzuxfKzOi-9bxghAG8VA1eq92jdJuoVlUBG7hl78is5ciR3EsuRgUYWZZLy4UUT8pEc232zFE7Fqw8pyhVqaHEiGw5OSYCaVpyhHjIk8IjRYNQHuLgNob-hDAfjBj-K6-Emv3oD4WAZMP3h0JdFLk1-JMYR6pyL-9EWAnRqOCJUZXMB1W3IGqjTUD8g0ejFqAx-b9rARmksQgjtV1wewRB6RyxGGUkA87tCCi29bRnFzd6Df-WrK1aTclYf5oWZHSngiSeTC7qz4gL-lZVk2wXxrjavYY9Y3f3wyJ6NELKAwbXECtdYsbCJRJGeqpqqh27t1eZVnnbnbrrNJZaVY2m3hkxMtA7VUj99o0HBlhtEXY49S8_Bc1Z56Zs1PEnDEvYXGSaz8

Basedpyright Playground:
https://basedpyright.com/?pythonVersion=3.15&typeCheckingMode=all&code=MQAgsgrgLghgRgGwKYgQSwM5RJnA7ANxgCc0Y8oBYAKHSwEYAuVTKAbTQoF0QBeENvQAMXGnSgAmZuI4UQAHxAA5APZ4kPfuPohQAUWLEVxGjVABJALaXo8ZCywgAFFAgAHZAEocGEAGMVIlJyKmpXDyQmEHDkWSgAGhAAOhTNZ2FEzxoYpClo91jObEVVdUSUpLScnVBVEAMjE2ozcFtEFAATND9sXE4gsgoaLp6okfYsYkSitIBvACIYeeZhAF9h7slmcbZJ6bkStQ0%2BEHGa%2BsNjEFNqC2s2%2B3GfEBgEDBV8AZCAfl-vmgAZmdmACjAAvJB4HZ7fBQNKglQQqGbJwAKgWS0Yayy1CBmzyCKR0KgU1hCmUR3hZ10F0aLQAQtAQOZogALTgAazZuAwrJUEAQHRAeBU2DgKHIICQlyaFm5eC5AGkkABPF5QkAANVeEBQvP5gpAcBUotZRpQAS%2BQ2oQA

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions