Repository navigation
Fixes split_args handling of quotes that start or end inside an argument. - #439
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_argsparses theExecutableArgumentsandWindowedExecutableArgumentsvalues of PEP 514 registrations. It only handles quotes that wrap a whole argument. When a quote starts or ends inside an argument, the parser keeps a stray quote (-W"ignore"becomes-W"ignore) or drops text ("a b"cbecomesa b). It also collapses\\outside quotes and turns doubled spaces into empty arguments.This change replaces the parser with a character-by-character implementation of the C runtime rules:
2nbackslashes followed by a quote producenbackslashes and toggle quoting.2n+1backslashes followed by a quote producenbackslashes and a literal quote.The new
test_split_argscases include the examples from Parsing C command-line arguments. The existingquote_argsround-trip cases still pass.Fixes #438