Skip to content

Meta: Add a note about populating the PR from a template. - #3474

Merged
hugovk merged 5 commits into
python:mainfrom
freakboy3742:pep-pr-creation
Oct 12, 2023
Merged

hugovk merged 5 commits into
python:mainfrom
freakboy3742:pep-pr-creation

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Oct 10, 2023 •

Copy link
Copy Markdown
Contributor

In the process of submitting PEP730, I was confused about the process of populating the PEP from a template. This PR adds a note to the contribution guide so others don't hit the same problem.


📚 Documentation preview 📚: https://pep-previews--3474.org.readthedocs.build/

@freakboy3742
freakboy3742 requested a review from a team as a code owner October 10, 2023 15:08
Comment thread CONTRIBUTING.rst Resolved
Comment thread CONTRIBUTING.rst Resolved
Comment thread CONTRIBUTING.rst Resolved
Comment thread CONTRIBUTING.rst Resolved
freakboy3742 and others added 2 commits October 11, 2023 10:44
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk added the meta Related to the repo itself and its processes label Oct 12, 2023
@hugovk
hugovk merged commit 6c817a6 into python:main Oct 12, 2023
@encukou

encukou commented Oct 12, 2023

Copy link
Copy Markdown
Member

FWIW, I I do use the link that these instructions boldly discourage, and I copy the template from the file in .github/PULL_REQUEST_TEMPLATES. It's useful to see the checklist as I work on the changes.

But probably not useful enough to complicate the instructions.

@freakboy3742
freakboy3742 deleted the pep-pr-creation branch October 12, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the repo itself and its processes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants