Skip to content

gh-158314: Fix test_parameters_deep_recursion on 32-bit ARM #161847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aozmekik wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

gh-158314: Fix test_parameters_deep_recursion on 32-bit ARM #161847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
from test.support import (
captured_stderr, cpython_only, requires_docstrings, import_helper, run_code,
subTests, EqualToForwardRef,
exceeds_recursion_limit, run_with_limited_c_stack,
run_with_limited_c_stack,
skip_wasi_stack_overflow, skip_emscripten_stack_overflow,
)
from test.typinganndata import (
Expand Down Expand Up @@ -5097,12 +5097,14 @@ class MM2(collections.abc.MutableMapping, MutableMapping[str, str]):
self.assertEqual(MM2.__bases__, (collections.abc.MutableMapping, Generic))

@cpython_only
@run_with_limited_c_stack()
@run_with_limited_c_stack(500_000)
@skip_wasi_stack_overflow()
@skip_emscripten_stack_overflow()
def test_parameters_deep_recursion(self):
# _Py_make_parameters() has small C frames (48 bytes per level
# on 32-bit ARM), so 150_000 levels can fit in the limited C stack.
x = [0]
for _ in range(exceeds_recursion_limit()):
for _ in range(500_000):
x = [x]
with self.assertRaisesRegex(RecursionError, "in __parameter__ calculation"):
list[x].__parameters__
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-11-12-05-39-56.gh-issue-158314.SZiMPV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix ``test_typing.GenericTests.test_parameters_deep_recursion`` on 32-bit
ARM debug builds, where 150,000 nested lists did not exhaust the limited C
stack.
Loading