Skip to content

[3.12] gh-161705: Prevent shadowing stdlib in gzip/tarfile/zipfile CLI - #161727

Open
vstinner wants to merge 1 commit into
python:3.12from
vstinner:sys_path0_12
Open

vstinner wants to merge 1 commit into
python:3.12from
vstinner:sys_path0_12

Conversation

@vstinner

Copy link
Copy Markdown
Member

gh-161705: Prevent shadowing stdlib in gzip/tarfile/zipfile CLI (#161706)

Remove sys.path[0] in gzip, tarfile and zipfile command line interface to prevent shadowing standard library modules from extracted files.

  • Add sys._path0 variable.
  • pymain_sys_path_add_path0() sets sys._path0.
  • Add runpy._remove_sys_path0().
  • gzip, tarfile and zipfile main functions now call _remove_sys_path0() to prevent shadowing stdlib modules from extracted files.

Backport to 3.12: add test.support.make_clean_env().

(cherry picked from commit e891a91)

(cherry picked from commit 8aa5d65)

…ile CLI (python#161706) (python#161719)

pythongh-161705: Prevent shadowing stdlib in gzip/tarfile/zipfile CLI (python#161706)

Remove sys.path[0] in gzip, tarfile and zipfile command line
interface to prevent shadowing standard library modules from
extracted files.

* Add sys._path0 variable.
* pymain_sys_path_add_path0() sets sys._path0.
* Add runpy._remove_sys_path0().
* gzip, tarfile and zipfile main functions now call
  _remove_sys_path0() to prevent shadowing stdlib modules from
  extracted files.

Backport to 3.12: add test.support.make_clean_env().

(cherry picked from commit e891a91)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
(cherry picked from commit 8aa5d65)
@vstinner

Copy link
Copy Markdown
Member Author

Tests / Thread sanitizer / Thread sanitizer (pull_request): Failing after 5m

test_large_content_length_truncated() of test_httpservers failed with BrokenPipeError: [Errno 32] Broken pipe. I saw this test failing on some builldbots on 3.11 - 3.13 branches. Anyway, it's unrelated to my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants