Repository navigation
Conversation
…ontiguousStrides()
Davien21
requested review from
a team,
AA-Turner,
emmatyping,
erlend-aasland and
itamaro
as code owners
October 26, 2026 09:27
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
|
Opened gh-161081 for the different-shapes case mentioned above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
_testlimitedcapiwrappers and tests forPyObject_CopyData()andPyBuffer_FillContiguousStrides(), which had none. Same layout as gh-158102: a newModules/_testlimitedcapi/buffer.candLib/test/test_capi/test_buffer.py.The
PyObject_CopyData()tests cover C and Fortran contiguous 2-D copies in all four combinations, non-contiguous sources and destinations, multi-byte items, and the error paths. They don't cover copies between buffers of different shapes, because that path gives wrong results today; I'll open a separate issue for it.Tested with a
--with-pydebugbuild:./python -m test -j4 test_capi test_bufferpasses. Breaking the strided copy loop and the Fortran branch ofPyBuffer_FillContiguousStrides()inObjects/abstract.cmakes all three new tests fail.