Repository navigation
Conversation
fr_department() converted string input with int(), which also accepts surrounding whitespace, a sign, underscores and non-ASCII decimal digits, so values such as " 75", "+75", "7_5" or fullwidth "75" validated. Match the string against [0-9]+ before converting it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fr_department()converts string input withint(), which also accepts surrounding whitespace, a leading sign, underscores and any Unicode decimal digit (docs). These all validate onmaster:#532 required ASCII digits in
fr_ssn()and the other regional identifiers; this does the same forfr_department()by matching the string against[0-9]+before converting it. Integer input and the2A/2BCorsica codes are unchanged.The six values above are added to the invalid-department cases in
tests/i18n/test_fr.py; they fail without the change.tests/i18n/test_fr.pypasses (44 passed), as does the rest of the suite apart from theeth_addresstests, which need the optionaleth-hashdependency not installed here.ruff checkandruff format --checkpass.