You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spanish identifier validators accept non-ASCII letters after case conversion #575
The numeric-body ASCII checks added in #519 do not reject non-ASCII letters in prefix/control positions before uppercase normalization.
On current master:
fromvalidatorsimportes_nif, es_nie, es_cif, es_doies_nif("00000038\u017f") # True; long s becomes Ses_nif("00000038\u00df") # True; sharp s expands to SSes_nie("X0000038\u00df") # Truees_cif("\u017f0000000J") # True
The DOI dispatcher accepts the same malformed identifiers. Expected: ValidationError for these values, while valid ASCII identifiers and their existing accepted case variants keep working. In the sharp-s case the input passes the original nine-character length check, then expands to ten characters, but validation ignores the extra letter.
Impact: invalid tax/identity identifiers pass validation even though their characters are outside the expected ASCII alphabet. I assess this as medium severity, not a maintainer-applied label. Eight regressions fail on unchanged master; a focused fix moves ASCII checking ahead of case conversion for the complete identifier. Codex assisted with investigation and tests.
Activity